Skip to content

Commit

Permalink
List mode: Remove temporary pixel (#5024)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1205278999335242/1207870191742638/f

### Description

This PR removes the temporary pixel used by the list tab mode.
  • Loading branch information
0nko authored Sep 20, 2024
1 parent 607177a commit 91541a0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ enum class AppPixelName(override val pixelName: String) : Pixel.PixelName {
TAB_MANAGER_REARRANGE_TABS_DAILY("m_tab_manager_rearrange_tabs_daily"),
TAB_MANAGER_GRID_VIEW_BUTTON_CLICKED("m_tab_manager_grid_view_button_clicked"),
TAB_MANAGER_LIST_VIEW_BUTTON_CLICKED("m_tab_manager_list_view_button_clicked"),
TAB_MANAGER_VIEW_MODE_TOGGLED_DAILY("m_tab_manager_view_mode_toggled_daily"),

DUCK_PLAYER_SETTING_ALWAYS_OVERLAY_YOUTUBE("duck-player_setting_always_overlay_youtube"),
DUCK_PLAYER_SETTING_ALWAYS_SERP("duck-player_setting_always_overlay_serp"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,6 @@ class TabSwitcherViewModel @Inject constructor(

fun onLayoutTypeToggled() {
viewModelScope.launch(dispatcherProvider.io()) {
pixel.fire(AppPixelName.TAB_MANAGER_VIEW_MODE_TOGGLED_DAILY, emptyMap(), emptyMap(), DAILY)

val newLayoutType = if (layoutType.value == GRID) {
pixel.fire(AppPixelName.TAB_MANAGER_LIST_VIEW_BUTTON_CLICKED)
LIST
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@ class TabSwitcherViewModelTest {

testee.onLayoutTypeToggled()

verify(mockPixel).fire(AppPixelName.TAB_MANAGER_VIEW_MODE_TOGGLED_DAILY, emptyMap(), emptyMap(), Pixel.PixelType.DAILY)
verify(mockPixel).fire(AppPixelName.TAB_MANAGER_LIST_VIEW_BUTTON_CLICKED)
}

Expand All @@ -354,7 +353,6 @@ class TabSwitcherViewModelTest {

testee.onLayoutTypeToggled()

verify(mockPixel).fire(AppPixelName.TAB_MANAGER_VIEW_MODE_TOGGLED_DAILY, emptyMap(), emptyMap(), Pixel.PixelType.DAILY)
verify(mockPixel).fire(AppPixelName.TAB_MANAGER_GRID_VIEW_BUTTON_CLICKED)
}

Expand Down

0 comments on commit 91541a0

Please sign in to comment.