Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 2743 nrl gfs cloud analysis #2850

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Dec 24, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran the use case and tested to be sure it works as expected

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Run the use case to verify that it runs and produces the expected output (clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer.conf). Review the documentation for any errors and inconsistencies.
    Steps to run the use case:

  1. The data is located on seneca in the following directories:
    /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/GFS_0.25
    /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/analysis
    /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/masks
  2. Check out the feature_2743_nrl_gfs_cloud_analysis branch of METplus
  3. Minna's mp_analysis_env conda environment on seneca has all the necessary packages:/d1/personal/mwin/miniconda3/envs
  4. Check out the develop branch of METcalcpy, METplotpy, and METdataio. These branches need to be in your Python path or conda environment. Currently, the Python path is set in the use case for these repositories to be in the same directory as the METplus repository. If the locations are different, this will need to be changed in the [user_env_vars] section of the .conf file
  5. Run the use case and verify that the output matches the output in the following directories on seneca:
    Mask: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/masks/West_Pacific.nc

Grid-Stat: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/grid_stat

MODE: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/mode

Stat-Analysis: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/stat_analysis

Reformatted data: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/reformatted/reformat_CTS.data

Plots: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/plots

The use case will take a while to run (an hour for me on seneca). It runs in 18 mins on GitHub actions due to ci overrides.

The documentation for review is here: https://metplus.readthedocs.io/en/feature_2743_nrl_gfs_cloud_analysis/generated/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer.html#sphx-glr-generated-model-applications-clouds-gridstat-fcstgfs-obsgfs-cloudfraclayer-py

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    Yes

  • Do these changes include sufficient testing updates? [Yes or No]
    Yes

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:
    No

  • Please complete this pull request review by [Fill in date].

    Dec 30?

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb added the requestor: Navy/NRL Naval Research Laboratory label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requestor: Navy/NRL Naval Research Laboratory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Use Case: construct use case verifying GFS cloud forecasts vs. GFS cloud analyses
1 participant