-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2743 nrl gfs cloud analysis #2850
Open
CPKalb
wants to merge
20
commits into
develop
Choose a base branch
from
feature_2743_nrl_gfs_cloud_analysis
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Ran the use case and tested to be sure it works as expected
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Run the use case to verify that it runs and produces the expected output (clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer.conf). Review the documentation for any errors and inconsistencies.
Steps to run the use case:
/d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/GFS_0.25
/d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/analysis
/d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/masks
Mask: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/masks/West_Pacific.nc
Grid-Stat: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/grid_stat
MODE: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/mode
Stat-Analysis: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/stat_analysis
Reformatted data: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/reformatted/reformat_CTS.data
Plots: /d1/personal/kalb/NRL/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer/plots
The use case will take a while to run (an hour for me on seneca). It runs in 18 mins on GitHub actions due to ci overrides.
The documentation for review is here: https://metplus.readthedocs.io/en/feature_2743_nrl_gfs_cloud_analysis/generated/model_applications/clouds/GridStat_fcstGFS_obsGFS_cloudFracLayer.html#sphx-glr-generated-model-applications-clouds-gridstat-fcstgfs-obsgfs-cloudfraclayer-py
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Yes
Do these changes include sufficient testing updates? [Yes or No]
Yes
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
No
Please complete this pull request review by [Fill in date].
Dec 30?
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases