-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2741 datsets and workflow #2839
base: develop
Are you sure you want to change the base?
Conversation
…41_datsets_and_workflow
…er/METplus into feature_2741_datsets_and_workflow
…41_datsets_and_workflow
…41_datsets_and_workflow
…41_datsets_and_workflow
@lisagoodrich Just trying to figure out where we're at with this PR. Did you finish the datasets and workflow work or was this PR submitted prematurely due to the request to stop work? |
@jprestop The work is completed to the best of my ability. I have questions for you to review highlighted in blue on the spreadsheet. I have a feeling there will be things I should have done or still need to do but this was my best college try. If we had more time, I would have discussed with you before the pull request. But since I got a "stop work" I thought this would be good enough and better than no pull request and nothing to show for all the hours I put into this. I hope this answer helps. |
Pull Request Testing
Describe testing already performed for these changes:
This portion of the pull request focused on matching the "datasets" and "METplus Workflow" sections to the template and filling in missing information. I did the best I could with the available information. For the "METplus Workflow" section, I pulled data from the conf files under the params directory. Please review the spreadsheet for specifics about each file.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please double check these sections for content and formatting corrections.
As of 12/16/24 My hours on the NRL project have run out and Dan A. has asked me to stop working on this. (Perhaps I can charge another project if there are questions or corrections that need to be made.)
This was tedious work and this needs further future review by a scientist to ensure that these sections have the correct information.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Wait for direction from @DanielAdriaansen ].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases