-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2735 v6.0.0 beta6 #2736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d logging to alert users what is happening when timely github queries are running
JohnHalleyGotway
requested review from
JohnHalleyGotway
and removed request for
jprestop
October 18, 2024 18:32
JohnHalleyGotway
previously approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, I approve of these changes, but did make a few suggestions on the PR for your consideration, along with this:
- Consider using
Task
for task template issues instead ofInternal
to avoid confusion. - I note that none of the release notes are bolded. Please review and use your judgement to highlight any that should be emphasized.
- I reviewed the rendered release notes and like how you've set the script up to strip the prefix off of the issue title.
- This is very subjective, but I always reword to the bugfix issues to state: "Fix {ABC} to do {XYZ}". Otherwise, we end up with a lot of variability in how info is communicated. Up to your discretion though.
- Reminder that issue templates only take effect when in the default branch. So you may want to make the same changes in
main_v5.1
or consider switching to usingdevelop
as the default branch. - Recommend updating the
Release Guide
instructions for writing release notes to point to the new utility script, along with debugging issues running it on seneca.
…ut version is a beta or rc version to preserve previous behavior of GHA scripts. Update GHA scripts to use new option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides adding the release notes and updating the version file, I added:
Review release notes here:
https://metplus--2736.org.readthedocs.build/en/2736/Users_Guide/release-notes.html