Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
The METdbLoad met_db_load.py code now performs validation against a schema to conform with AF Cybersecurity checks for recursive payloads and extremely large payloads. This results in strict conformance to a schema, where
element values must conform to length limits, number of elements, and elements must appear in a specific order.
The only file affected is the XML specification file in parm/use_cases/met_tool_wrapper/METdbLoad/METdbLoadConfig.xml
Testing:
re-ran all GHA tests
activated all short-range use case tests (these are the use cases that utilize the METdbLoad XML specification files to load data)
verified that all the above tests pass
returned short-range use case tests back to original state (run=false)
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
verify that all tests are passing
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [NA]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [before beta6 release].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases