per #2540, remove quality_mark_thresh from config file because it has…

… been removed from MET point2grid
dtcenter · Oct 2, 2024 · e545402 · e545402
1 parent 0676c86
commit e545402
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 29 deletions.
diff --git a/docs/Users_Guide/glossary.rst b/docs/Users_Guide/glossary.rst
@@ -11659,11 +11659,6 @@ METplus Configuration Glossary
 
      | *Used by:* Point2Grid
 
-   POINT2GRID_QUALITY_MARK_THRESH
-     Specify the value for 'quality_mark_thresh' in the MET configuration file for Point2Grid.
-
-     | *Used by:* Point2Grid
-
    POINT2GRID_OBS_QUALITY_INC
      Specify the value for 'obs_quality_inc' in the MET configuration file for Point2Grid.
 

diff --git a/docs/Users_Guide/wrappers.rst b/docs/Users_Guide/wrappers.rst
@@ -6881,7 +6881,6 @@ METplus Configuration
 | :term:`POINT2GRID_MESSAGE_TYPE`
 | :term:`POINT2GRID_VAR_NAME_MAP<n>_KEY`
 | :term:`POINT2GRID_VAR_NAME_MAP<n>_VAL`
-| :term:`POINT2GRID_QUALITY_MARK_THRESH`
 | :term:`POINT2GRID_OBS_QUALITY_INC`
 | :term:`POINT2GRID_OBS_QUALITY_EXC`
 | :term:`POINT2GRID_TIME_OFFSET_WARNING`
@@ -6969,18 +6968,6 @@ ${METPLUS_VAR_NAME_MAP_LIST}
    * - :term:`POINT2GRID_VAR_NAME_MAP<n>_VAL`
      - var_name_map.val
 
-${METPLUS_QUALITY_MARK_THRESH}
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-.. list-table::
-   :widths: 5 5
-   :header-rows: 1
-
-   * - METplus Config(s)
-     - MET Config File
-   * - :term:`POINT2GRID_QUALITY_MARK_THRESH`
-     - quality_mark_thresh
-
 ${METPLUS_OBS_QUALITY_INC}
 ^^^^^^^^^^^^^^^^^^^^^^^^^^
 

diff --git a/internal/tests/pytests/wrappers/point2grid/test_point2grid.py b/internal/tests/pytests/wrappers/point2grid/test_point2grid.py
@@ -115,9 +115,6 @@ def test_point2grid_missing_inputs(metplus_config, get_test_data_dir,
           },
          {'METPLUS_VAR_NAME_MAP_LIST': 'var_name_map = [{key = "13";val = "LUCKY";},{key = "3";val = "MAGIC";}];'}, []),
 
-        ({'POINT2GRID_QUALITY_MARK_THRESH': '3', },
-         {'METPLUS_QUALITY_MARK_THRESH': 'quality_mark_thresh = 3;'}, []),
-
         ({'POINT2GRID_OBS_QUALITY_INC': '0, 1, 2', },
          {'METPLUS_OBS_QUALITY_INC': 'obs_quality_inc = ["0", "1", "2"];'}, []),
 

diff --git a/metplus/wrappers/point2grid_wrapper.py b/metplus/wrappers/point2grid_wrapper.py
@@ -33,7 +33,6 @@ class Point2GridWrapper(ReformatPointWrapper):
         'METPLUS_OBS_WINDOW_DICT',
         'METPLUS_MESSAGE_TYPE',
         'METPLUS_VAR_NAME_MAP_LIST',
-        'METPLUS_QUALITY_MARK_THRESH',
         'METPLUS_OBS_QUALITY_INC',
         'METPLUS_OBS_QUALITY_EXC',
     ]
@@ -125,7 +124,6 @@ def create_c_dict(self):
                                                     'val': 'string'}):
             self.isOK = False
 
-        self.add_met_config(name='quality_mark_thresh', data_type='int')
         self.add_met_config(name='obs_quality_inc', data_type='list',
                             metplus_configs=['POINT2GRID_OBS_QUALITY_INC',
                                              'POINT2GRID_OBS_QUALITY_INCLUDE',

diff --git a/parm/met_config/Point2GridConfig_wrapped b/parm/met_config/Point2GridConfig_wrapped
@@ -38,11 +38,6 @@ ${METPLUS_VAR_NAME_MAP_LIST}
 
 ////////////////////////////////////////////////////////////////////////////////
 
-//quality_mark_thresh =
-${METPLUS_QUALITY_MARK_THRESH}
-
-////////////////////////////////////////////////////////////////////////////////
-
 //obs_quality_inc = [
 ${METPLUS_OBS_QUALITY_INC}
 

diff --git a/parm/use_cases/met_tool_wrapper/Point2Grid/Point2Grid.conf b/parm/use_cases/met_tool_wrapper/Point2Grid/Point2Grid.conf
@@ -68,6 +68,8 @@ POINT2GRID_REGRID_METHOD = MAX
 POINT2GRID_INPUT_FIELD =TMP
 POINT2GRID_INPUT_LEVEL =
 
+#POINT2GRID_GOES_QC_FLAGS =
+
 POINT2GRID_ADP =
 
 POINT2GRID_GAUSSIAN_DX = 81.271
@@ -83,7 +85,6 @@ POINT2GRID_VLD_THRESH =
 #POINT2GRID_MESSAGE_TYPE =
 #POINT2GRID_VAR_NAME_MAP1_KEY =
 #POINT2GRID_VAR_NAME_MAP1_VAL =
-#POINT2GRID_QUALITY_MARK_THRESH =
 #POINT2GRID_OBS_QUALITY_INC =
 #POINT2GRID_OBS_QUALITY_EXC =