Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert plot_tcmpr.R plotting to Python #240

Closed
21 tasks
TaraJensen opened this issue Jul 6, 2022 · 0 comments · Fixed by #322
Closed
21 tasks

Convert plot_tcmpr.R plotting to Python #240

TaraJensen opened this issue Jul 6, 2022 · 0 comments · Fixed by #322
Assignees
@bikegeek @TatianaBurek @hankenstein2
Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Milestone
METplotpy-2.1.0

Comments

@TaraJensen
Copy link

TaraJensen commented Jul 6, 2022 •
edited by TatianaBurek
Loading

Replace italics below with details for this issue.

Describe the New Feature

We need to convert plot_tcmpr.R script to remove the dependency on R-statistics from METplus
https://github.com/NCAR/MET/tree/develop/met/scripts/Rscripts

This is related to the METcalcpy issue: dtcenter/METcalcpy#189
This is also related to METviewer issue: dtcenter/METviewer#171

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2793541 (old, Tara asked not to charge) , 2773542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TaraJensen TaraJensen added type: new feature Make it do something new alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle reporting: DTC NOAA R2O NOAA Research to Operations DTC Project labels Jul 6, 2022
@TaraJensen TaraJensen added this to the METplotpy-2.0 milestone Jul 6, 2022
@TaraJensen TaraJensen mentioned this issue Jul 6, 2022
Closed
21 tasks
@bikegeek bikegeek added the required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone label Jul 28, 2022
@TatianaBurek TatianaBurek removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Sep 6, 2022
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
add tickformat to xaxes #240
92478fa
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
initial version #240
3504ee0
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
initial version #240
0937fd1
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
initial version #240
cbdba40
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
fixed the type of config_value in calculate_plot_dimension to string #…
c4ace2e 
…240
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
add more plotly markers #240
33b37d3
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
check if image name is not None before removing the old image #240
f276c02
TatianaBurek added a commit that referenced this issue Feb 27, 2023
@TatianaBurek
initial version #240
6bf19ee
@TatianaBurek TatianaBurek linked a pull request Feb 27, 2023 that will close this issue
Feature 240 tcmpr #322
Merged
13 tasks
bikegeek pushed a commit that referenced this issue Feb 28, 2023
@TatianaBurek
Feature 240 tcmpr (#322)
3f95ada 
* add tickformat to xaxes #240

* initial version #240

* initial version #240

* initial version #240

* fixed the type of config_value in calculate_plot_dimension to string  #240

* add more plotly markers  #240

* check if image name is not None before removing the old image  #240

* initial version #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

@TatianaBurek TatianaBurek

@hankenstein2 hankenstein2

Labels
alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Projects
No open projects
METplus-Analysis-5.1.0 Development
Status: ✅ Done
Milestone
METplotpy-2.1.0
Development

Successfully merging a pull request may close this issue.

Feature 240 tcmpr dtcenter/METplotpy
5 participants
@bikegeek @JohnHalleyGotway @TatianaBurek @TaraJensen @hankenstein2