Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert plot_tcmpr.R calculations to Python #189

Closed
21 tasks
TaraJensen opened this issue Jul 6, 2022 · 0 comments · Fixed by #288
Closed
21 tasks

Convert plot_tcmpr.R calculations to Python #189

TaraJensen opened this issue Jul 6, 2022 · 0 comments · Fixed by #288
Assignees
Labels
reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new

Comments

@TaraJensen
Copy link

TaraJensen commented Jul 6, 2022

Describe the New Feature

We need to convert plot_tcmpr.R script to remove the dependency on R-statistics from METplus
https://github.com/NCAR/MET/tree/develop/met/scripts/Rscripts

This is related to the METplotpy issue: dtcenter/METplotpy#240
This is also related to METviewer issue: dtcenter/METviewer#171

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TaraJensen TaraJensen added type: new feature Make it do something new alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle reporting: DTC NOAA R2O NOAA Research to Operations DTC Project labels Jul 6, 2022
@TaraJensen TaraJensen added this to the METcalcpy-2.0 milestone Jul 6, 2022
@TaraJensen TaraJensen changed the title Convert plot_tcmpr.R to python Convert plot_tcmpr.R calculations to Python Jul 6, 2022
@bikegeek bikegeek added required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jul 28, 2022
@TatianaBurek TatianaBurek modified the milestones: METcalcpy-2.0, METcalcpy 2.1.0 beta1 Feb 28, 2023
@TatianaBurek TatianaBurek linked a pull request Feb 28, 2023 that will close this issue
13 tasks
@JohnHalleyGotway JohnHalleyGotway modified the milestones: METcalcpy 2.1.0 beta1, METcalcpy 2.1.0 Mar 7, 2023
@jprestop jprestop removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting: DTC NOAA R2O NOAA Research to Operations DTC Project required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants