Fix our container image size #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this will prevent Couchbase from being rebuilt by Meteor/NPM. Once rebuilt, it takes up a large amount of space in the image.
Use the corrected npm-shrinkwrap.json file.
ian-noaa
changed the title
MATS ignores the .npm directory in MATScommon as well. This prevents Meteor from using the .npm/packages/npm-shrinkwrap.json file and so Meteor pulls in the correct NPM package for the architecture. Otherwise, Meteor will try to rebuild from source and greatly increase the image size. Additionally, reorganized the .dockerignore and updated the exclude rules to better target artifacts that shouldn't be brought into the image.
Reactivate our container image scanning, set the pipeline timeout back to 30 minutes, and re-enable fail-fast builds
mollybsmith-noaa
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
cmakefrom ourDockerfileto prevent Couchbase from being rebuilt by Meteor/NPM. If Couchbase is built from source it takes up a large amount of space in the image..dockerignoreto match MATS - it appears to be important to exclude MATScommon's.npm/packages/npm-shrinkwrap.jsonfile from the docker container build.Closes #132