feature 497 headers #336
Merged
feature 497 headers #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@lisagoodrich I changed the Project from METplus-Wrappers-6.0.0 Development to METplus-Analysis-6.0.0 Development since this PR is for METcalcpy and not for METplus wrappers. I also changed the Milestone from METcalcpy-2.1.1 Bugfix to METcalcpy-3.0.0 since this isn't a bugfix but rather a change for the upcoming release. |
jprestop
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Thanks @lisagoodrich for your work on this task. I have verified that all tests pass. I approve this request.
|
@jprestop who do I ask to Merge this pull request? I'm unable to merge it. Thank you for making corrections to the projects and developments. |
|
HI @lisagoodrich. I'm sorry, I always forget that you do not have squash and merge permissions here. :( I will take care of it. |
jprestop
added a commit
that referenced
this pull request
Feb 2, 2024
* Prepare for next release * add missing end quote to fix package install * reset_index is performed on the float value #322 (#323) * Update release notes (#328) * Update release-notes.rst formatting * Update and rename 2.1.0_wcoss2 to 3.0.0_wcoss2 * loop over statistics only once to avoid data multiplication #330 (#331) * Added sphinx_rtd_theme to extensions * Updated requirements.txt * Added pillow * feature 497 headers (#336) * changing header for continuity * Modified the other headers in the file to be consistent with other repos --------- Co-authored-by: Julie Prestopnik <[email protected]> * Beta2 release (#338) * Next version * Feature 332 di doc (#333) * Add difficulty index documentation * Add more documentation * Add more definition * Fix indent * Add figure * fix indentation * fix equations * Add table * Added remaining tables * fix table issue * Add links * formatting * change link to latest --------- Co-authored-by: Tracy <[email protected]> * Additions to beta2 release (#340) * Next beta * Bugfix 329 negative bcmse (#344) * Issue #329 return 0 if negative BCMSE value is calculated * Issue #329 add test for calculate_bcmse() in the sl1l2_statistics module * Issue #392 added test_sl1l2.py to the list of pytests to run * command line updates * updating yaml file --------- Co-authored-by: Hank Fisher <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: Tatiana Burek <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: Tracy Hertneky <[email protected]> Co-authored-by: Tracy <[email protected]> Co-authored-by: bikegeek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
. This issue had to be re-opened due to confusion about the best way to label index.rst files. They are treated differently depending on where they are located. Below are notes from @jprestop.
dtcenter/METviewer#502 (comment)
@lisagoodrich Thanks for all of your work on this task. I added a few suggestions that you can just accept the changes for, however, for the top level docs/index.rst, could you please change those headers back to what they were? Let me know if you want to talk about this again, but we had discussed how the top level index wasn't really a "part" whereas the User's Guide's and Contributor's Guide's index.rst files were "parts". So, we decided just to leave the top level index.rst files alone. You can verify this by looking at the already merged METplotpy file (https://raw.githubusercontent.com/dtcenter/METplotpy/develop/docs/index.rst) and the already merged METplus file (https://raw.githubusercontent.com/dtcenter/METplus/develop/docs/index.rst). METcalcpy was also completed but it looks like it is not the same as the others and needs to be fixed as well (https://raw.githubusercontent.com/dtcenter/METcalcpy/develop/docs/index.rst) - apologies for missing that in PR review of METcalcpy.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Confirm the header change is correct, using = instead of #.
Please squash and merge and close the branch. I don't have permission to do this.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No errors]
[ x Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [11/13/23].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes