Update README.md #321
Merged
Update README.md #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update required Python version to 3.10+
hankenstein2
approved these changes
Aug 1, 2023
hankenstein2
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Update README.md (#321) update required Python version to 3.10+ * Added aggregation features * Test * removed folders * Added aggregation features * Updates settings and improved folder search algorithm; Added README * Corrected FBIAS stat fields * Create Aggregation.rst creating file from:https://github.com/dtcenter/METcalcpy/blob/feature_325_aggregation_support/metcalcpy/pre_processing/aggregation/README.md Copied Vertical Interpolation as a template * adding aggregation * Rename Aggregation.rst to aggregation.rst * first pass at cleaning up warnings * changing to 3rd person * issue #325 CTS data from RRFS to test aggregation * Issue #325 added background on agg_stat.py * issue #325 added instructions for bash and csh, added links to external references * issue #325 fix syntax for subsection * Issue #325 fix grammar, add instructions for importing and invoked by another script * issue #325 more fixes to grammar for import instructions * issue #325 added corrected instructions for running via command-line (included the path to the agg_stat.py module) * Issue #325 modify config file to specify valid paths for input and output files. * Issue #325 modified for User's Guide instructions * issue #325 added reformatted data for ECNT and compatible for METcalcpy agg_stat input * Delete test/data/rrfs_cts_reformatted.data not used for testing. Using the ECNT data instead. * issue #325 pytest on ECNT data reformatted with METdataio METreformat and aggregation statistics calculated * issue #325 added latest test for ECNT aggregation * Issue #325 address pandas future warning that causes current pytests to fail. Remove pandas chaining such as: df['column_name'][index] = var_name with: df.loc[index, 'column_name'] = var_name * Issue #325 address pandas future warning that causes current pytests to fail. Remove pandas chaining such as: df['column_name'][index] = var_name with: df.loc[index, 'column_name'] = var_name * Issue #325 updated input data to ECNT data, corrected the explanation of expected input format for agg_stat. * Issue #325 modify config file to use RRFS ECNT .stat data reformatted by METdataio * issue #325 point to actual config file via literalinclude * issue #325 replace reference to the CTS output file with ECNT * replace pandas append with concat * Update unit_tests.yml added test_reformatted_for_agg.py * fixed syntax error with list * issue #325 update test data with correctly reformatted ECNT line data * issue #325 removed some unneccessary text --------- Co-authored-by: VanderleiVargas-NOAA <[email protected]> Co-authored-by: lisagoodrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update required Python version to 3.10+
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes