Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3038 nc_dim_log #3039

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Feature #3038 nc_dim_log #3039

merged 2 commits into from
Dec 17, 2024

Conversation

JohnHalleyGotway
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Manually ran commands listed in the issue to confirm log messages are as stated.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Feel free to test out functionality in seneca /d1/projects/MET/MET_pull_requests/met-12.1.0/beta1/MET-feature_3038_nc_dim_log

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    None needed.

  • Do these changes include sufficient testing updates? [No]
    None needed.

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Wed 12/18/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Contributor

@DanielAdriaansen DanielAdriaansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran plot_data_plane on Seneca using the test build and verbosity 10 and saw this log message:

WARNING: 
WARNING: check_dim_offset() -> Found non-integer NetCDF dimension index (0.5 != 0).
WARNING: Did you intend to use "@0.5" to specify the value for that dimension instead?
WARNING: 

I approve. Thanks @JohnHalleyGotway!

@JohnHalleyGotway JohnHalleyGotway linked an issue Dec 16, 2024 that may be closed by this pull request
21 tasks
@JohnHalleyGotway
Copy link
Collaborator Author

Note that I did some SonarQube cleanup on this branch to reduce the overall number of code smells from 18,222 in the develop branch to 18,210 in the branch for this PR.

@JohnHalleyGotway JohnHalleyGotway merged commit 0600e02 into develop Dec 17, 2024
38 of 40 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_3038_nc_dim_log branch December 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Improve logging for NetCDF level dimension matches
2 participants