-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #2924 parse_config PR 2 #2975
Commits on Sep 3, 2024
-
Per #2924, remove GenEnsProd config file comment about parsing desc s…
…eparately from each obs.field entry because the obs dictionary does not exist in the GenEnsProd config file.
Configuration menu - View commit details
-
Copy full SHA for 285eeb2 - Browse repository at this point
Copy the full SHA 285eeb2View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e9ce34f - Browse repository at this point
Copy the full SHA e9ce34fView commit details -
Per #2924, remove const from the parent() member function so that we …
…can perform lookups for the parent.
Configuration menu - View commit details
-
Copy full SHA for c1c4f9b - Browse repository at this point
Copy the full SHA c1c4f9bView commit details -
Per #2924, update the signature for and logic of the utility function…
…s that retrieve the climatology data. Rather than requiring all the climo_mean and climo_stdev dictionary entries to be defined at the same config file context level, parse each one individually. This enables the METplus wrappers to only partially override this dictionary and still rely on the default values provided in MET's default configuration files.
Configuration menu - View commit details
-
Copy full SHA for d0ac39a - Browse repository at this point
Copy the full SHA d0ac39aView commit details -
Per #2924, update all calls to the climatology utility functions base…
…d on the new function signature. Also update the tools to check the number of climo fields separately for the forecast and observation climos.
Configuration menu - View commit details
-
Copy full SHA for 5435d74 - Browse repository at this point
Copy the full SHA 5435d74View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8ddfcc - Browse repository at this point
Copy the full SHA f8ddfccView commit details -
Per #2924, update the parsing logic for the climatology regrid dictio…
…nary. Use config.fcst.climo_mean.regrid first, config.fcst.regrid second, and config.climo_mean.regrid third. Notably, DO NOT use config.regrid. This is definitely the problem with having regrid specified at mutliple config file context levels. It makes the logic for which to use when very messy.
MET Tools Test Account committedSep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 0e21fa6 - Browse repository at this point
Copy the full SHA 0e21fa6View commit details -
Per #2924, forgot to add an else to print an error
MET Tools Test Account committedSep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for f256940 - Browse repository at this point
Copy the full SHA f256940View commit details -
Per #2924, remove extraneous semicolon
MET Tools Test Account committedSep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 347c644 - Browse repository at this point
Copy the full SHA 347c644View commit details -
Per #2924, move 'fcst.regrid' into 'fcst.climo_mean.regrid'. Defining…
… the climatology regridding logic inside fcst is problematic because it applies to the forecast data as well and you end up with the verification grid being undefined. So the climo regridding logic must be defined in 'climo_mean.regrid' either within the 'fcst' and 'obs' dictionaries or at the top-level config context.
Configuration menu - View commit details
-
Copy full SHA for 343f9b3 - Browse repository at this point
Copy the full SHA 343f9b3View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9cc932b - Browse repository at this point
Copy the full SHA 9cc932bView commit details
Commits on Sep 12, 2024
-
Per #2924, based on PR feedback from @georgemccabe, add the Upper_Lef…
…t, Upper_Right, Lower_Right, and Lower_Left interpolation methods to the list of valid options for regridding, as already indicated in the MET User's Guide.
Configuration menu - View commit details
-
Copy full SHA for 7849d5d - Browse repository at this point
Copy the full SHA 7849d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6edd245 - Browse repository at this point
Copy the full SHA 6edd245View commit details -
Per #2924, update the logic of parse_conf_regrid() to (hopefully) mak…
…e it work the way @georgemccabe expects it to. It now uses pointers to both the primary and default dictionaries and parses each entry individually.
Configuration menu - View commit details
-
Copy full SHA for 1563d97 - Browse repository at this point
Copy the full SHA 1563d97View commit details -
Per #2924, need to check for non-null pointer before using it
MET Tools Test Account committedSep 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 364ec6d - Browse repository at this point
Copy the full SHA 364ec6dView commit details
Commits on Sep 13, 2024
-
Per #2924, revise the climo_name dictionary lookup logic when parsing…
… the regrid dictionary.
Configuration menu - View commit details
-
Copy full SHA for c71c72e - Browse repository at this point
Copy the full SHA c71c72eView commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa719a1 - Browse repository at this point
Copy the full SHA fa719a1View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2a68a35 - Browse repository at this point
Copy the full SHA 2a68a35View commit details -
Per #2924, remove the default regridding information from the 'Search…
…ing' log message to avoid confusion.
Configuration menu - View commit details
-
Copy full SHA for d47d4f7 - Browse repository at this point
Copy the full SHA d47d4f7View commit details
Commits on Sep 18, 2024
-
Merge remote-tracking branch 'origin/develop' into feature_2924_parse…
…_config
MET Tools Test Account committedSep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 37d3ca5 - Browse repository at this point
Copy the full SHA 37d3ca5View commit details -
Per #2924, escape sequences, like \n, cannot be used inside R-string …
…literals.
MET Tools Test Account committedSep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 372016e - Browse repository at this point
Copy the full SHA 372016eView commit details -
Per #2924, update the logic of check_climo_n_vx()
MET Tools Test Account committedSep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for ea0c70a - Browse repository at this point
Copy the full SHA ea0c70aView commit details -
Per #2924, revise logic in read_climo_data_plane_array(). Check the n…
…umber of climo fields provided. If there's 0, just return since no data has been requested. If there's 1, use it regardless of the number of input fields. If there's more than 1, just use the requested i_vx index value.
MET Tools Test Account committedSep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 227a552 - Browse repository at this point
Copy the full SHA 227a552View commit details -
Per #2924, update Series-Analysis to set both i_fcst and i_obs when l…
…ooping over the series entries.
MET Tools Test Account committedSep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for ecbb7b1 - Browse repository at this point
Copy the full SHA ecbb7b1View commit details -
Per #2924, no real change. Just whitespace.
MET Tools Test Account committedSep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for cc9c78d - Browse repository at this point
Copy the full SHA cc9c78dView commit details
Commits on Sep 19, 2024
-
Unrelated to #2924, superficial changes to formatting of method_name …
…strings for consistency.
MET Tools Test Account committedSep 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 394fb8d - Browse repository at this point
Copy the full SHA 394fb8dView commit details -
Per #2924, add a new series_analysis test that ERRORS OUT prior to th…
…is PR but works after the changes in this PR.
Configuration menu - View commit details
-
Copy full SHA for 0f722ee - Browse repository at this point
Copy the full SHA 0f722eeView commit details