Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2924 parse_config PR 2 #2975

Merged
merged 27 commits into from
Sep 19, 2024
Merged

Commits on Sep 3, 2024

  1. Per #2924, remove GenEnsProd config file comment about parsing desc s…

    …eparately from each obs.field entry because the obs dictionary does not exist in the GenEnsProd config file.
    JohnHalleyGotway committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    285eeb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    e9ce34f View commit details
    Browse the repository at this point in the history
  2. Per #2924, remove const from the parent() member function so that we …

    …can perform lookups for the parent.
    JohnHalleyGotway committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c1c4f9b View commit details
    Browse the repository at this point in the history
  3. Per #2924, update the signature for and logic of the utility function…

    …s that retrieve the climatology data. Rather than requiring all the climo_mean and climo_stdev dictionary entries to be defined at the same config file context level, parse each one individually. This enables the METplus wrappers to only partially override this dictionary and still rely on the default values provided in MET's default configuration files.
    JohnHalleyGotway committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d0ac39a View commit details
    Browse the repository at this point in the history
  4. Per #2924, update all calls to the climatology utility functions base…

    …d on the new function signature. Also update the tools to check the number of climo fields separately for the forecast and observation climos.
    JohnHalleyGotway committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5435d74 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f8ddfcc View commit details
    Browse the repository at this point in the history
  6. Per #2924, update the parsing logic for the climatology regrid dictio…

    …nary. Use config.fcst.climo_mean.regrid first, config.fcst.regrid second, and config.climo_mean.regrid third. Notably, DO NOT use config.regrid. This is definitely the problem with having regrid specified at mutliple config file context levels. It makes the logic for which to use when very messy.
    MET Tools Test Account committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0e21fa6 View commit details
    Browse the repository at this point in the history
  7. Per #2924, forgot to add an else to print an error

    MET Tools Test Account committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f256940 View commit details
    Browse the repository at this point in the history
  8. Per #2924, remove extraneous semicolon

    MET Tools Test Account committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    347c644 View commit details
    Browse the repository at this point in the history
  9. Per #2924, move 'fcst.regrid' into 'fcst.climo_mean.regrid'. Defining…

    … the climatology regridding logic inside fcst is problematic because it applies to the forecast data as well and you end up with the verification grid being undefined. So the climo regridding logic must be defined in 'climo_mean.regrid' either within the 'fcst' and 'obs' dictionaries or at the top-level config context.
    JohnHalleyGotway committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    343f9b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    9cc932b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Per #2924, based on PR feedback from @georgemccabe, add the Upper_Lef…

    …t, Upper_Right, Lower_Right, and Lower_Left interpolation methods to the list of valid options for regridding, as already indicated in the MET User's Guide.
    JohnHalleyGotway committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7849d5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6edd245 View commit details
    Browse the repository at this point in the history
  3. Per #2924, update the logic of parse_conf_regrid() to (hopefully) mak…

    …e it work the way @georgemccabe expects it to. It now uses pointers to both the primary and default dictionaries and parses each entry individually.
    JohnHalleyGotway committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1563d97 View commit details
    Browse the repository at this point in the history
  4. Per #2924, need to check for non-null pointer before using it

    MET Tools Test Account committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    364ec6d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    c71c72e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    fa719a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    2a68a35 View commit details
    Browse the repository at this point in the history
  2. Per #2924, remove the default regridding information from the 'Search…

    …ing' log message to avoid confusion.
    JohnHalleyGotway committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d47d4f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge remote-tracking branch 'origin/develop' into feature_2924_parse…

    …_config
    MET Tools Test Account committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    37d3ca5 View commit details
    Browse the repository at this point in the history
  2. Per #2924, escape sequences, like \n, cannot be used inside R-string …

    …literals.
    MET Tools Test Account committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    372016e View commit details
    Browse the repository at this point in the history
  3. Per #2924, update the logic of check_climo_n_vx()

    MET Tools Test Account committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ea0c70a View commit details
    Browse the repository at this point in the history
  4. Per #2924, revise logic in read_climo_data_plane_array(). Check the n…

    …umber of climo fields provided. If there's 0, just return since no data has been requested. If there's 1, use it regardless of the number of input fields. If there's more than 1, just use the requested i_vx index value.
    MET Tools Test Account committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    227a552 View commit details
    Browse the repository at this point in the history
  5. Per #2924, update Series-Analysis to set both i_fcst and i_obs when l…

    …ooping over the series entries.
    MET Tools Test Account committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ecbb7b1 View commit details
    Browse the repository at this point in the history
  6. Per #2924, no real change. Just whitespace.

    MET Tools Test Account committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    cc9c78d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Unrelated to #2924, superficial changes to formatting of method_name …

    …strings for consistency.
    MET Tools Test Account committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    394fb8d View commit details
    Browse the repository at this point in the history
  2. Per #2924, add a new series_analysis test that ERRORS OUT prior to th…

    …is PR but works after the changes in this PR.
    JohnHalleyGotway committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0f722ee View commit details
    Browse the repository at this point in the history