Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 2652 polar CF #2764

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Bugfix 2652 polar CF #2764

merged 2 commits into from
Dec 14, 2023

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Dec 13, 2023

MET did not recognize the coordinate variable by using the standard name, "projection_x_coordinate" and "projection_y_coordinate". They are recognized as the coordinate variables

Changed literal 0 to nullptr (SonarQube code smell).

The fix for Bugfix: Refine support for coordinate dimensions in CF-compliant NetCDF files at main_V11.1 was applied to the develop branch (line 260 at nccf_file.cc)

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

/d1/personal/hsoh/git/pull_request/MET_bugfix_2652_polar_CF/bin/plot_data_plane /d1/personal/hsoh/data/MET-2652/seaice_conc_monthly_sh_202208_f17_v04r00.nc nccf_polar_xy.ps 'name="cdr_seaice_conc_monthly"; level="(0,,)";' -v 4

DEBUG 4: Stereographic Grid Data:
DEBUG 4:   hemisphere: S
DEBUG 4:    scale_lat: -90
DEBUG 4:      lat_pin: -39.2753
DEBUG 4:      lon_pin: -137.767
DEBUG 4:        x_pin: 0
DEBUG 4:        y_pin: 0
DEBUG 4:   lon_orient: -180
DEBUG 4:         d_km: 25
DEBUG 4:        dy_km: -25
DEBUG 4:         r_km: 6371.2
DEBUG 4:           nx: 316
DEBUG 4:           ny: 332
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

N/A

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop changed the title #2652 Added find_var_by_standard_name and separated common codes to find_xy_vars Bugfix 2652 polar CF Dec 14, 2023
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing, @hsoh-u, and for making these changes. I have reviewed the changes and ensured that all tests passed. Additionally, I changed the title to ensure the PR title matched the bugfix branch name. I approve this request.

@hsoh-u hsoh-u merged commit ea9e543 into develop Dec 14, 2023
35 checks passed
@hsoh-u hsoh-u deleted the bugfix_2652_polar_CF branch December 14, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
2 participants