Bugfix 2428 python from env main v11.0 #2443

hsoh-u · 2023-02-15T23:57:49Z

Expected Differences

If MET_PYTHON_EXE is defined, the met_point_data should be saved as temporary NetCDF file and MET reads the NetCDF file. The log message shows if the temporary file was created. MET deletes the temporary file.
Without the environment variable MET_PYTHON_EXE

DEBUG 3: Running user's python script (../../../../scripts/python/read_met_point_obs).
DEBUG 2: Processing 78376 observations at 8465 locations.

With the environment variable MET_PYTHON_EXE

DEBUG 3: Calling /usr/local/met-python3/bin/python3.8 to run user's python script (../../../../scripts/python/read_met_point_obs).
DEBUG 4: Writing temporary Python point data file:
DEBUG 4:        /usr/local/met-python3/bin/python3.8 /d1/personal/hsoh/git/bugfixes/bugfix_2428_python_from_env_main_v11.0/MET/share/met/wrappers/write_tmp_point_nc.py /dev/shm/hsoh/tmp/tmp_met_nc_18941_0 ../../../../scripts/python/read_met_point_obs /d1/personal/hsoh/MET/test_output/NB/pb2nc/ndas.20120409.t12z.prepbufr.tm00.nc
  python: Python Script:        '/d1/personal/hsoh/git/bugfixes/bugfix_2428_python_from_env_main_v11.0/MET/share/met/wrappers/write_tmp_point_nc.py'
  python: User Command: '../../../../scripts/python/read_met_point_obs /d1/personal/hsoh/MET/test_output/NB/pb2nc/ndas.20120409.t12z.prepbufr.tm00.nc'
  python: Temporary File:       '/dev/shm/hsoh/tmp/tmp_met_nc_18941_0'
  python: Done python script ../../../../scripts/python/read_met_point_obs took 0:00:00.045950
DEBUG 4: Reading temporary Python point data file: /dev/shm/hsoh/tmp/tmp_met_nc_18941_0
DEBUG 2: Processing 78376 observations at 8465 locations.

Note: The following log message was not added for 11.0 branch because MET_PYTHON_BIN_EXE was not introduced at 11.0 branch.

DEBUG 3: Initializing python: /usr/local/met-python3/bin/python3.8

Do these changes introduce new tools, command line arguments, or configuration file options? [No]

If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

If yes, please describe:

Pull Request Testing

Describe testing already performed for these changes:

at seneca:

export MET_BASE=/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met
export MET_PYTHON_EXE=/usr/local/met-python3/bin/python3.8

/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs \
   'PYTHON_NUMPY=/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/scripts/python/read_met_point_obs.py /d1/personal/hsoh/MET/test_output/NB/pb2nc/ndas.20120409.t12z.prepbufr.tm00.nc' \
  pointdata_numpy.ps -dotsize 2.0 -v 4 | grep -v "Plotting location"

unset MET_PYTHON_EXE

/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs \
   'PYTHON_NUMPY=/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/scripts/python/read_met_point_obs.py /d1/personal/hsoh/MET/test_output/NB/pb2nc/ndas.20120409.t12z.prepbufr.tm00.nc' \
  pointdata_numpy.ps -dotsize 2.0 -v 4 | grep -v "Plotting location"

Test from #2428

export MET_BASE=/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met
export MET_PYTHON_EXE=/usr/local/met-python3/bin/python3.8

/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs \
  "PYTHON_NUMPY=/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/scripts/python/read_ascii_point.py /d1/projects/MET/MET_releases/MET-11.0.0/data/sample_obs/ascii/sample_ascii_obs.txt" \
  test.ps -v 4 | grep -v "Plotting location"

Added unit test

/d1/personal/hsoh/git/bugfixes/bugfix_2428_python_from_env_main_v11.0/MET/internal/test_unit/perl/unit.pl /d1/personal/hsoh/git/bugfixes/bugfix_2428_python_from_env_main_v11.0/MET/internal/test_unit/xml/unit_python.xml -log unit_python.log

TEST: python_point2grid_pb2nc_TMP                       - pass -   2.072 sec
TEST: python_point2grid_pb2nc_TMP_user_python           - pass -   3.281 sec

Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [Yes]

Unittest "python_point2grid_pb2nc_TMP_user_python" was added. It should produce the same output with python_point2grid_pb2nc_TMP (pb2nc_TMP.nc and pb2nc_TMP_user_python.nc).

Will this PR result in changes to the test suite? [No]

If yes, describe the new output and/or changes to the existing output:

No except a new output python/pb2nc_TMP_user_python.nc

Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

Review the source issue metadata (required labels, projects, and milestone).
Complete the PR definition above.
Ensure the PR title matches the feature or bugfix branch name.
Define the PR metadata, as permissions allow.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes
After submitting the PR, select Development issue with the original issue number.
After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
Close the linked issue and delete your feature or bugfix branch from GitHub.

…_util.cc & python3_util.h

georgemccabe

The changes to the logs that list the version of Python used as described in this comment weren't implemented here.

I think it would be best for @DanielAdriaansen to test running with these changes to ensure the output matches what he expects.

hsoh-u · 2023-02-17T21:43:06Z

The changes to the logs that list the version of Python used as described in this comment weren't implemented here.

I think it would be best for @DanielAdriaansen to test running with these changes to ensure the output matches what he expects.

How to get the compile time python exe?
Is MET_PYTHON_BIN_EXE available at main_v11.0 branch?

georgemccabe · 2023-02-17T21:48:18Z

The changes to the logs that list the version of Python used as described in this comment weren't implemented here.
I think it would be best for @DanielAdriaansen to test running with these changes to ensure the output matches what he expects.

How to get the compile time python exe? Is MET_PYTHON_BIN_EXE available at main_v11.0 branch?

I'm sorry, I didn't realize this was for main_v11.0. I don't think any log changes are needed.

sys.path.append(os.path.abspath(os.path.join(os.path.dirname(file),

Modified read_tmp_point_nc.py & write_tmp_point_nc.py (github and /d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0).
Dan, would you test it without MET_BASE settting?

unset MET_BASE

DanielAdriaansen · 2023-02-17T21:50:31Z

@hsoh-u should met_point_obs be able to be automatically found in 11.0.0? Or is that only going to be available in future releases?

I am running this command on seneca:

export MET_PYTHON_EXE=/home/met_test/.conda/envs/metplus_base.v5/bin/python3
/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs "PYTHON_NUMPY=/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point.py /d1/projects/MET/MET_releases/MET-11.0.0/data/sample_obs/ascii/sample_ascii_obs.txt" test.ps -v 3

But get this error:

DEBUG 3: Calling /home/met_test/.conda/envs/metplus_base.v5/bin/python3 to run user's python script (/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point).
Traceback (most recent call last):
  File "/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met/wrappers/write_tmp_point_nc.py", line 19, in <module>
    from met_point_obs import met_point_obs
ModuleNotFoundError: No module named 'met_point_obs'

hsoh-u · 2023-02-17T21:58:50Z

@hsoh-u should met_point_obs be able to be automatically found in 11.0.0? Or is that only going to be available in future releases?

I am running this command on seneca:

export MET_PYTHON_EXE=/home/met_test/.conda/envs/metplus_base.v5/bin/python3
/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs "PYTHON_NUMPY=/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point.py /d1/projects/MET/MET_releases/MET-11.0.0/data/sample_obs/ascii/sample_ascii_obs.txt" test.ps -v 3

But get this error:

DEBUG 3: Calling /home/met_test/.conda/envs/metplus_base.v5/bin/python3 to run user's python script (/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point).
Traceback (most recent call last):
  File "/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met/wrappers/write_tmp_point_nc.py", line 19, in <module>
    from met_point_obs import met_point_obs
ModuleNotFoundError: No module named 'met_point_obs'

It depends on MET_BASE setting. MET adds MET_BASE/python and MET_BASE/wrappers into the system path for python. If MET_BASE is not set, it fails to find "met_point_obs.py" which is in MET_BASE/python directory ("/python" and "/wrappers" are added to the system path).

Please check if this helps:

export MET_BASE=/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met

DanielAdriaansen · 2023-02-17T22:10:30Z

OK, that helps thank you Howard. Now I am getting this error:

DEBUG 3: Calling /home/met_test/.conda/envs/metplus_base.v5/bin/python3 to run user's python script (/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point).
Traceback (most recent call last):
  File "/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met/wrappers/write_tmp_point_nc.py", line 19, in <module>
    from met_point_obs import met_point_obs
  File "/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met/python/met_point_obs.py", line 27, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'

I think this is related to #2386 is that right?

It looks like NumPy is listed already as a dependency for MET Python Embedding, so I think this is OK, and I will change to a Python environment that has NumPy because apparently /home/met_test/.conda/envs/metplus_base.v5/bin/python3 on Seneca does not.

I am adding a note on #2414 to suggest unifying the Python requirements for METplus wrappers and the requirements for a Python to use when building MET for Python Embedding support.

DanielAdriaansen · 2023-02-17T22:13:43Z

@georgemccabe regarding Howard's comment:

It depends on MET_BASE setting. MET adds MET_BASE/python and MET_BASE/wrappers into the system path for python. If MET_BASE is not set, it fails to find "met_point_obs.py" which is in MET_BASE/python directory ("/python" and "/wrappers" are added to the system path).

Does METplus wrappers set MET_BASE somehow? I know that MET_INSTALL_DIR is required for the METplus wrappers, so I am wondering if MET_BASE is set automatically or not set by METplus wrappers.

hsoh-u · 2023-02-17T22:14:43Z

OK, that helps thank you Howard. Now I am getting this error:
DEBUG 3: Calling /home/met_test/.conda/envs/metplus_base.v5/bin/python3 to run user's python script (/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point).
Traceback (most recent call last):
  File "/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met/wrappers/write_tmp_point_nc.py", line 19, in <module>
    from met_point_obs import met_point_obs
  File "/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/share/met/python/met_point_obs.py", line 27, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'
I think this is related to #2386 is that right?

It looks like NumPy is listed already as a dependency for MET Python Embedding, so I think this is OK, and I will change to a Python environment that has NumPy because apparently /home/met_test/.conda/envs/metplus_base.v5/bin/python3 on Seneca does not.

I am adding a note on #2414 to suggest unifying the Python requirements for METplus wrappers and the requirements for a Python to use when building MET for Python Embedding support.

No, it's not.
The python3 you are using does not have the numpy package as is. You may need to activate the conda.

(base) hsoh@seneca:MET$ /home/met_test/.conda/envs/metplus_base.v5/bin/python3 -c "import numpy"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'numpy'

DanielAdriaansen · 2023-02-17T22:23:59Z

Is there an open issue to log MET_PYTHON_BIN_EXE in future versions? If not, I can create one.

hsoh-u · 2023-02-17T22:24:11Z

@georgemccabe regarding Howard's comment:

It depends on MET_BASE setting. MET adds MET_BASE/python and MET_BASE/wrappers into the system path for python. If MET_BASE is not set, it fails to find "met_point_obs.py" which is in MET_BASE/python directory ("/python" and "/wrappers" are added to the system path).

Does METplus wrappers set MET_BASE somehow? I know that MET_INSTALL_DIR is required for the METplus wrappers, so I am wondering if MET_BASE is set automatically or not set by METplus wrappers.

Not sure without METplus configuration. I set MET_BASE manually as needed at seneca.
MET_BASE is not defined at internal/scripts/environment/development.seneca

georgemccabe · 2023-02-17T22:29:10Z

I believe MET_BASE is set to a default value of where MET is installed. The wrappers do not override this value.

You shouldn't have to set MET_BASE to include the python directory in the path. It is added in other files by using the relative path from the script. See:

MET/data/wrappers/write_tmp_dataplane.py

Lines 25 to 26 in eb987a4

    
           sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), 
        
                                                        os.pardir, 'python')))

@georgemccabe regarding Howard's comment:

It depends on MET_BASE setting. MET adds MET_BASE/python and MET_BASE/wrappers into the system path for python. If MET_BASE is not set, it fails to find "met_point_obs.py" which is in MET_BASE/python directory ("/python" and "/wrappers" are added to the system path).

Does METplus wrappers set MET_BASE somehow? I know that MET_INSTALL_DIR is required for the METplus wrappers, so I am wondering if MET_BASE is set automatically or not set by METplus wrappers.

DanielAdriaansen · 2023-02-17T22:33:46Z

@hsoh-u can you please add the code @georgemccabe sent from write_tmp_dataplane.py to write_tmp_point_nc.py?

hsoh-u · 2023-02-17T22:37:57Z

Is there an open issue to log MET_PYTHON_BIN_EXE in future versions? If not, I can create one.

I don't think this is an issues. The log already exists for python embedding of gridded data (MET v11.1 development version) or the existing log message should be changed as @georgemccabe mentioned this comment. The same log should be added for the python embedding of the point observation data. But it can not be added to the 11.0 branch for both (python embedding of gridded and point data).

DanielAdriaansen · 2023-02-17T22:54:24Z

Is there an open issue to log MET_PYTHON_BIN_EXE in future versions? If not, I can create one.

I don't think this is an issues. The log already exists for python embedding of gridded data (MET v11.1 development version). The same log should be added for the python embedding of the point observation data. But it can not be added to the 11.0 branch for both (python embedding of gridded and point data).

OK, that makes sense. Then will this PR also be merged into MET v11.1 development version?

hsoh-u · 2023-02-17T23:04:38Z

@hsoh-u can you please add the code @georgemccabe sent from write_tmp_dataplane.py to write_tmp_point_nc.py?

Updated at github repository

Sorry my script does not allow new build for Pull Request to the different location.

/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0 was renamed to /d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0_rev1
- Two python scripts are updated here (read_tmp_point_nc.py and write_tmp_point_nc.py)
New checkout is done at /d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0 and the build was started

DanielAdriaansen · 2023-02-17T23:23:28Z

I performed the following testing on seneca with the new changes.

TEST 1

/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs "PYTHON_NUMPY=/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point.py /d1/projects/MET/MET_releases/MET-11.0.0/data/sample_obs/ascii/sample_ascii_obs.txt" test.ps -v 3

This worked as expected, and worked previously.

TEST 2

export MET_PYTHON_EXE=/home/dadriaan/.conda/envs/icing/bin/python3
/d1/personal/hsoh/git/pull_request/MET_bugfix_2428_python_from_env_main_v11.0/bin/plot_point_obs "PYTHON_NUMPY=/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point.py /d1/projects/MET/MET_releases/MET-11.0.0/data/sample_obs/ascii/sample_ascii_obs.txt" test.ps -v 3

This would also have worked previously, but would have silently used the same Python as TEST 1, instead of MET_PYTHON_EXE Python.

The output from TEST 2 now correctly informs me MET is using MET_PYTHON_EXE Python to run the Python embedding:

DEBUG 3: Calling /home/dadriaan/.conda/envs/icing/bin/python3 to run user's python script (/d1/projects/MET/MET_releases/MET-11.0.0/scripts/python/read_ascii_point).

Howard also added additional changes so that a user does not need to set MET_BASE when using MET_PYTHON_EXE in order for met_point_obs to be able to be imported, consistent with write_tmp_dataplane.py.

In future versions, the addition of MET_PYTHON_BIN_EXE will make it clear to the user in TEST 1 that the Python MET was built with is being used, but this feature is not available in main_v11.0.0 so that is not currently the case.

In addition, @georgemccabe shared with me this change:
5ad920b
which will allow Python embedding in the future if MET_PYTHON_EXE is unset to still find met_point_obs without the user needing to set MET_BASE.

DanielAdriaansen

I approve.

JohnHalleyGotway · 2023-02-20T18:20:46Z

Merging this PR into main_v11.0 based on @DanielAdriaansen's approving review.

Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> fix #2389 main_v11.0 flowchart (#2391) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405) fix #2380 main_v11.0 override (#2381) fix #2408 main_v11.0 empty config (#2409) fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403) fix #2415 main_v11.0 modulefiles (#2416) fix #2412 main_v11.0 climo (#2420) fix #2426 main_v11.0 buoy (#2432) fix #2437 main_v11.0 convert (#2438) fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix 2428 python from env main v11.0 (#2443) fix 2428 python csv input (#2450) fix #2452 main_v11.0 airnow (#2453) fix #2402 main_v11.0 sonarqube (First PR) (#2447)

Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> fix #2389 main_v11.0 flowchart (#2391) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405) fix #2380 main_v11.0 override (#2381) fix #2408 main_v11.0 empty config (#2409) fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403) fix #2415 main_v11.0 modulefiles (#2416) fix #2412 main_v11.0 climo (#2420) fix #2426 main_v11.0 buoy (#2432) fix #2437 main_v11.0 convert (#2438) fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix 2428 python from env main v11.0 (#2443) fix 2428 python csv input (#2450) fix #2452 main_v11.0 airnow (#2453) fix #2402 main_v11.0 sonarqube (First PR) (#2447) fix #2449 main_v11.0 pdf (#2465) fix 2428 python csv input (#2467)

Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: Stephen Herbener <[email protected]> fix #2389 main_v11.0 flowchart (#2391) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405) fix #2380 main_v11.0 override (#2381) fix #2408 main_v11.0 empty config (#2409) fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403) fix #2415 main_v11.0 modulefiles (#2416) fix #2412 main_v11.0 climo (#2420) fix #2426 main_v11.0 buoy (#2432) fix #2437 main_v11.0 convert (#2438) fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix 2428 python from env main v11.0 (#2443) fix 2428 python csv input (#2450) fix #2452 main_v11.0 airnow (#2453) fix #2402 main_v11.0 sonarqube (First PR) (#2447) fix #2449 main_v11.0 pdf (#2465) fix 2428 python csv input (#2467) fix #2514 main_v11.0 clang (#2556) fix #2575 main_v11.0 python_convert (#2577) fix 2596 main v11.0 rpath compilation (#2600) fix 2596 main v11.0 rpath compilation (#2613) fix #2644 main_v11.0 percentile (#2645)

…2770) Co-authored-by: MET Tools Test Account <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: John Halley Gotway <[email protected]> Co-authored-by: jprestop <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: George McCabe <[email protected]> Co-authored-by: lisagoodrich <[email protected]> Co-authored-by: Stephen Herbener <[email protected]> fix #2389 main_v11.0 flowchart (#2391) fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2405) fix #2380 main_v11.0 override (#2381) fix #2408 main_v11.0 empty config (#2409) fix #2390 main_v11.0 fix compiling hdf5 with zlib and handle NetCDF-C zip (#2403) fix #2415 main_v11.0 modulefiles (#2416) fix #2412 main_v11.0 climo (#2420) fix #2426 main_v11.0 buoy (#2432) fix #2437 main_v11.0 convert (#2438) fix for main_v11.0, for #2437, forgot one reference to the search_parent for a dictionary lookup. fix 2428 python from env main v11.0 (#2443) fix 2428 python csv input (#2450) fix #2452 main_v11.0 airnow (#2453) fix #2402 main_v11.0 sonarqube (First PR) (#2447) fix #2449 main_v11.0 pdf (#2465) fix 2428 python csv input (#2467) fix #2514 main_v11.0 clang (#2556) fix #2575 main_v11.0 python_convert (#2577) fix 2596 main v11.0 rpath compilation (#2600) fix 2596 main v11.0 rpath compilation (#2613) fix #2644 main_v11.0 percentile (#2645)

Howard Soh added 10 commits February 15, 2023 15:16

#2428 Initial release

7722790

#2428 Added read_tmp_point_nc.py and write_tmp_point_nc.py

43efa64

#2428 Added met_point_obs_nc.py

c96d2ac

#2428 Added python_point2grid_pb2nc_TMP_user_python

24ebd71

#2428 Moved GP, tmp_nc_base_name, and tmp_nc_file_var_name to python3…

982474a

…_util.cc & python3_util.h

#2428 Moved nc_tools to met_point_obs_nc.py

3e3fa56

#2428 Moved nc_point_obs to met_point_obs_nc.py

38e8f34

#2428 Added tmp_nc_point_obs

c414833

#2428 Use fstring

b770935

#2428 Turn on use_var_id for CSV

16e29c7

hsoh-u requested a review from JohnHalleyGotway February 15, 2023 23:57

This was linked to issues Feb 15, 2023

Bugfix: Fix the MET vx_pointdata_python library to handle MET_PYTHON_EXE for python embedding of point observations #2428

Closed

Convert the python list to the numpy array for the python embedding at the base class. #2386

Closed

hsoh-u requested review from georgemccabe and DanielAdriaansen and removed request for JohnHalleyGotway February 16, 2023 15:18

JohnHalleyGotway added this to the MET 11.0.1 (bugfix) milestone Feb 16, 2023

georgemccabe requested changes Feb 17, 2023

View reviewed changes

hsoh-u requested a review from georgemccabe February 17, 2023 22:07

#2428 Added path for met_point_obs.py

4146b24

DanielAdriaansen approved these changes Feb 17, 2023

View reviewed changes

DanielAdriaansen mentioned this pull request Feb 17, 2023

Convert the python list to the numpy array for the python embedding at the base class. #2386

Closed

21 tasks

JohnHalleyGotway merged commit ce07db1 into main_v11.0 Feb 20, 2023

JohnHalleyGotway deleted the bugfix_2428_python_from_env_main_v11.0 branch February 20, 2023 18:20

This was referenced Feb 20, 2023

Bugfix: Fix the MET vx_pointdata_python library to handle MET_PYTHON_EXE for python embedding of point observations #2428

Closed

Bugfix #2402 main_v11.0 sonarqube #2447

Merged

Update main_v11.0-ref after #2443, #2454, and #2455 #2456

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix 2428 python from env main v11.0 #2443

Bugfix 2428 python from env main v11.0 #2443

hsoh-u commented Feb 15, 2023

georgemccabe left a comment

hsoh-u commented Feb 17, 2023

georgemccabe commented Feb 17, 2023 •

edited by hsoh-u

Loading

DanielAdriaansen commented Feb 17, 2023

hsoh-u commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023 •

edited

Loading

hsoh-u commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023 •

edited

Loading

hsoh-u commented Feb 17, 2023

georgemccabe commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023

hsoh-u commented Feb 17, 2023 •

edited

Loading

DanielAdriaansen commented Feb 17, 2023

hsoh-u commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023

DanielAdriaansen left a comment

JohnHalleyGotway commented Feb 20, 2023

Bugfix 2428 python from env main v11.0 #2443

Bugfix 2428 python from env main v11.0 #2443

Conversation

hsoh-u commented Feb 15, 2023

Expected Differences

Pull Request Testing

Pull Request Checklist

georgemccabe left a comment

Choose a reason for hiding this comment

hsoh-u commented Feb 17, 2023

georgemccabe commented Feb 17, 2023 • edited by hsoh-u Loading

DanielAdriaansen commented Feb 17, 2023

hsoh-u commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023 • edited Loading

hsoh-u commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023 • edited Loading

hsoh-u commented Feb 17, 2023

georgemccabe commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023

hsoh-u commented Feb 17, 2023 • edited Loading

DanielAdriaansen commented Feb 17, 2023

hsoh-u commented Feb 17, 2023

DanielAdriaansen commented Feb 17, 2023

DanielAdriaansen left a comment

Choose a reason for hiding this comment

JohnHalleyGotway commented Feb 20, 2023

georgemccabe commented Feb 17, 2023 •

edited by hsoh-u

Loading

DanielAdriaansen commented Feb 17, 2023 •

edited

Loading

DanielAdriaansen commented Feb 17, 2023 •

edited

Loading

hsoh-u commented Feb 17, 2023 •

edited

Loading