Per #2583, simplify ObsErrorEntry::variance() implementation. For the…

… distribution type of NONE, return a variance of 0.0 rather than bad data, as discussed with @michelleharrold and @JeffBeck-NOAA on 3/8/2024.
dtcenter · Mar 8, 2024 · 449426c · 449426c
1 parent 14411de
commit 449426c
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/src/libcode/vx_statistics/obs_error.cc b/src/libcode/vx_statistics/obs_error.cc
@@ -186,13 +186,7 @@ void ObsErrorEntry::dump(ostream & out, int depth) const {
 ////////////////////////////////////////////////////////////////////////
 
 double ObsErrorEntry::variance() const {
-   double var = bad_data_double;
-
-   if(dist_type != DistType_None) {
-      var = dist_var(dist_type, dist_parm[0], dist_parm[1]);
-   }
-
-   return(var);
+   return dist_var(dist_type, dist_parm[0], dist_parm[1]);
 }
 
 ////////////////////////////////////////////////////////////////////////