Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not define IR_EXTERNAL_GDB_ENTRY in ir_php.h #94

Closed
wants to merge 1 commit into from

Conversation

arnaud-lb
Copy link
Contributor

@arnaud-lb arnaud-lb commented Oct 7, 2024

This is a follow-up of #93.

I think that IR_EXTERNAL_GDB_ENTRY should always be defined for PHP.

I propose to the definition from ir_php.h so that it can always be defined here.

Alternatively it could be defined unconditionally in ir_php.h.

@dstogov
Copy link
Owner

dstogov commented Oct 8, 2024

I have fixed this in ir_php.h.

@arnaud-lb
Copy link
Contributor Author

Thank you!

@arnaud-lb arnaud-lb closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants