Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct PathRef.prototype.renameSync docs #176

Merged
merged 1 commit into from
Sep 8, 2023
Merged

docs: correct PathRef.prototype.renameSync docs #176

merged 1 commit into from
Sep 8, 2023

Conversation

nettybun
Copy link
Contributor

@nettybun nettybun commented Sep 8, 2023

@nettybun
Copy link
Contributor Author

nettybun commented Sep 8, 2023

Also it looks like you're using the word "path" to mean PathRef? Which is cool once I tilt my head a bit but as a Node dev I keep thinking "path" means string...

Anyway thanks for the good project.

@dsherret dsherret changed the title Fix docs; no promise here docs: correct PathRef.prototype.renameSync docs Sep 8, 2023
dsherret
dsherret approved these changes Sep 8, 2023
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit 520cfc7 into dsherret:main Sep 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nettybun @dsherret