Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Sampler.DscPipeline version and added task Set_PSModulePath #154

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

raandree
Copy link
Contributor

@raandree raandree commented Apr 4, 2023

Pull Request

Pull Request (PR) description

In the latest version of Sampler.DscPipeline all code manipulating the PSModulePath was removed. Instead there is the task Set_PSModulePath.

The new task is configured in the build.yaml file:

####################################################
#           Setting Sampler PSModulePath           #
####################################################
SetPSModulePath:
  RemovePersonal: true
  RemoveProgramFiles: true

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@raandree raandree assigned raandree and nyanhp and unassigned raandree Apr 4, 2023
@nyanhp nyanhp merged commit 324afe6 into dsccommunity:main Apr 4, 2023
@raandree raandree deleted the feature/SetPsModulePath branch April 4, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants