Skip to content

Commit

Permalink
[ci] drop 2.6
Browse files Browse the repository at this point in the history
  • Loading branch information
@flash-gordon
flash-gordon committed Jan 13, 2022
1 parent 936ad3a commit f39d392
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml.erb
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This file is synced from dry-rb/template-gem repo
<% default_rubies = ["3.1", "3.0", "2.7", "2.6", "jruby"] %>
<% default_rubies = ["3.1", "3.0", "2.7", "jruby"] %>
name: CI

on:
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
ruby-version: 2.7
- name: Install dependencies
run: gem install ossy --no-document
- name: Trigger release workflow
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/docsite.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Set up Ruby
uses: actions/setup-ruby@v1
with:
ruby-version: "2.6.x"
ruby-version: "2.7.x"
- name: Set up git user
run: |
git config --local user.email "[email protected]"
Expand Down Expand Up @@ -60,4 +60,3 @@ jobs:
GITHUB_LOGIN: dry-bot
GITHUB_TOKEN: ${{secrets.GH_PAT}}
run: ossy github workflow dry-rb/dry-rb.org ci

2 changes: 1 addition & 1 deletion .github/workflows/sync_configs.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up Ruby
uses: actions/setup-ruby@v1
with:
ruby-version: "2.6"
ruby-version: "2.7"
- name: Install dependencies
run: gem install ossy --no-document
- name: Update changelog.yml from commit
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This is a config synced from dry-rb/template-gem repo

AllCops:
TargetRubyVersion: 2.6
TargetRubyVersion: 2.7
NewCops: enable
Exclude:
- benchmarks/*.rb
Expand Down
2 changes: 1 addition & 1 deletion README.md.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

This library officially supports the following Ruby versions:

* MRI `<%= gemspec.fetch('required_ruby_version', '>= 2.6.0') %>`
* MRI `<%= gemspec.fetch('required_ruby_version', '>= 2.7.0') %>`
* jruby `>= 9.3`

## License
Expand Down
2 changes: 1 addition & 1 deletion gemspec.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Gem::Specification.new do |spec|
spec.metadata["source_code_uri"] = "https://github.com/dry-rb/<%= name %>"
spec.metadata["bug_tracker_uri"] = "https://github.com/dry-rb/<%= name %>/issues"

spec.required_ruby_version = <%= gemspec.fetch('required_ruby_version', '>= 2.6.0').inspect %>
spec.required_ruby_version = <%= gemspec.fetch('required_ruby_version', '>= 2.7.0').inspect %>

This comment has been minimized.

Sign in to view

Copy link
@nevans

nevans Jan 24, 2022 •
edited
Loading

I totally understand the various motivations to stop supporting 2.6 ASAP. Pattern matching, numbered block parameters, and forward compatibility with "real" keyword parameters that behave almost the same as 3.x, etc. But, as a a user, I wish you hadn't pulled across the board support for 2.6 prior to its EOL. Immediately after the 2.6 EOL is 100% fine.

This three month period between the latest release and the oldest maintained release going EOL is a great season for upgrading large apps and their dependencies (whether the apps are staying current and moving from 3.0 to 3.1, or lagging behind at 2.6 to 2.7). It adds a small bit of annoying friction to the upgrade process when gems can't be installed with maintained ruby versions. I go to check the changelog, and... the only change is the gemspec's required_ruby_version. It's still otherwise compatible! 😦

Anyway, this is really only a minor complaint. I'll have all of my apps upgraded to 2.7 soon, and once I'm there I'll quickly forget 2.6 syntax ever existed. 😉 Your time is precious, and I don't want undue burden for any maintainers. Thanks a lot!

This comment has been minimized.

Sign in to view

Copy link
@flash-gordon

flash-gordon Jan 25, 2022

Author Member

@nevans this kind of feedback is very much appreciated, thank you. Normally, we wouldn't go ahead of EOL, but at the moment there's a lot of stuff going on, we prepare a release of dry-system 1.0 and rom 6 (and hanami 2 afterward). It's easier to coordinate efforts via a unified version bump. It doesn't mean we'll release all gems at once, it's just those we happen to release won't require time to work on 2.6 stuff. The difference between 2.6/2.7 is quite significant and stepping forward can save a lot of trouble with all these keyword issues. Once things are settled, such rush updates will cease :) For instance, there's no big difference between 2.7 and 3.0 from the maintainer's point of view.

Feel free to share your thoughts in dry-rb/dry-rb.org#392

This comment has been minimized.

Sign in to view

Copy link
@nevans

nevans Jan 27, 2022

@flash-gordon thanks for the reply! Yeah, it totally makes sense. I can't really cope with the responsibility of a couple of gems (on top of my work and family responsibilities), let alone coordinate an entire ecosystem of gems like dry-*, rom and hanami! Much respect to the team.

Perhaps ironically, the keywords changes were probably the biggest reason this particular app of mine is still on 2.6. Getting to 2.7 required so many dependency updates (or replacements for old unmaintained gems). By waiting it out (and gradually upgrading gems one-by-one) most of those issues were fixed upstream! Every time I've rebased the 2.7 branch to see what's needed to finish the job, a bunch of errors and warnings simply vanish without my lifting a finger!

Anyway... I'm so excited to start using pattern matching and numbered block params in certain areas of my codebase. I've even been considering how I might sprinkle in ruby-next to transpile a few key files and use 3.0 syntax.

# to update dependencies edit project.yml
<% gemspec.fetch('runtime_dependencies', []).sort_by { |name, *| name }.each do |dep| -%>
Expand Down

0 comments on commit f39d392

Please sign in to comment.