Merge pull request #462 from tomgi/fix_nested_array_object

[changelog] fixed: Fix json-schema type of objects nested under arrays. Fixes #400
dry-rb · May 22, 2024 · 8f9c073 · 8f9c073
2 parents 85a9e0b + a7cb37e
commit 8f9c073
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/dry/schema/extensions/json_schema/schema_compiler.rb b/lib/dry/schema/extensions/json_schema/schema_compiler.rb
@@ -90,7 +90,7 @@ def visit(node, opts = EMPTY_HASH)
         def visit_set(node, opts = EMPTY_HASH)
           target = (key = opts[:key]) ? self.class.new(loose: loose?) : self
 
-          node.map { |child| target.visit(child, opts) }
+          node.map { |child| target.visit(child, opts.except(:member)) }
 
           return unless key
 

diff --git a/spec/extensions/json_schema/schema_spec.rb b/spec/extensions/json_schema/schema_spec.rb
@@ -27,6 +27,10 @@
 
         required(:roles).array(:hash) do
           required(:name).value(:string, min_size?: 12, max_size?: 36)
+
+          required(:metadata).hash do
+            required(:assigned_at).value(:time)
+          end
         end
 
         optional(:address).hash do
@@ -59,9 +63,19 @@
                   type: "string",
                   minLength: 12,
                   maxLength: 36
+                },
+                metadata: {
+                  type: "object",
+                  properties: {
+                    assigned_at: {
+                      format: "time",
+                      type: "string"
+                    }
+                  },
+                  required: %w[assigned_at]
                 }
               },
-              required: ["name"]
+              required: %w[name metadata]
             }
           },
           address: {