Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema of all SQLite migration tables #2958

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mlafeldt
Copy link

Based on #2658, but fixes all SQLite migrators.

@mirague
Copy link

mirague commented Sep 15, 2024

Fixes #2969

@mphill
Copy link

mphill commented Sep 16, 2024

@mirague @mlafeldt I can abandon my PR.

These migrations tables should be created with STRICT. https://www.sqlite.org/stricttables.html

STRICT would have caught this.

Thoughts?

@mlafeldt
Copy link
Author

STRICT would have caught this.

@mirague That's a good idea, but Drizzle doesn't seem to support adding STRICT yet (?).

So far, we've had 3 PRs fixing the issue, but unfortunately zero interest in reviewing/merging them. 😕

@mirague
Copy link

mirague commented Sep 21, 2024

Any clue of the process on how to get this merged?

@mlafeldt
Copy link
Author

@iksflow
Copy link

iksflow commented Oct 18, 2024

Thanks! I was suffering from the same issue.
I'm wating for this commit to be released.

@mlafeldt
Copy link
Author

I'm wating for this commit to be released.

@iksflow So are we. 😃

@mirague
Copy link

mirague commented Oct 19, 2024

I’m very surprised this hasn’t been merged/fixed after many months. SQLite migrations are pretty broken without this 🤨

@mirague
Copy link

mirague commented Oct 19, 2024

Any chance to get some eyes on fixing sqlite migrations support with drizzle? @AndriiSherman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants