zerofi integration #1407
Open
zerofi integration #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crispheaney
reviewed
Jan 9, 2025
|
|
||
| #[derive(Copy, Clone, bytemuck::Pod, bytemuck::Zeroable)] | ||
| #[repr(C)] | ||
| pub struct Market { |
There was a problem hiding this comment.
would be good to preface this we ZerofiMarket so its clear what it's used for (there are multiple Market accounts in this program)
| let market: Ref<Market> = Ref::map(data, |data| { | ||
| bytemuck::from_bytes(&data[..std::mem::size_of::<Market>()]) | ||
| }); | ||
| if market.discriminator != 4 { |
There was a problem hiding this comment.
dont you have to check owner program id?
| /// CHECK: checked in ix | ||
| pub zerofi_program: AccountInfo<'info>, | ||
| /// CHECK: checked in ix | ||
| pub zerofi_market: AccountInfo<'info>, |
| }; | ||
|
|
||
| Ok(ExternalSpotFill { | ||
| base_asset_amount_filled, |
There was a problem hiding this comment.
need to make sure this is a multiple of step size
| let max_quote_in = taker_quote_asset_amount.min(taker_max_quote_asset_amount); | ||
| (max_quote_in, taker_base_asset_amount) | ||
| } else { | ||
| (taker_base_asset_amount, taker_quote_asset_amount) |
There was a problem hiding this comment.
why dont you need to account for taker_max_quote_asset_amount in this block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fulfillment via zerofi:
InitializeZerofiFulfillmentConfig,UpdateZerofiFulfillmentConfigSpotFulfillmentType::Zerofisupported in spot fill instructions