Allow passing a single object to Model.create. #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #159
Enables:
It seems that you can pass the same parameters to
Model.create
in many different ways.Eg:
are all equivalent.
This PR limits this somewhat, as the first argument which is an object but not an array is assumed to be a single item to be created.
I think this is resonable.
I also think the way parameters are accepted is a little too flexible. Requiring that the first parameter is the item(s) to be created, and last parameter is the callback (with an optional middle options param) would make the code a bit easier to read.