Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Xiaomi Aqara Single Switch Module T1 (With Neutral) #4768

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Apr 14, 2021

  • Whitelist for binding
  • Calculate the correct power values
  • Do not expose current and voltage

_ Whitelist for binding
- Calculate the correct power values
- Do not expose current and voltage
@SwoopX SwoopX linked an issue Apr 14, 2021 that may be closed by this pull request
@manup manup added this to the v2.11.1 milestone Apr 18, 2021
Copy link

@andudi andudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compilation error in de_web_plugin.cpp:9417
-> only two closing brackets instead of three
-> and after the brackets the or operator (||) is missing

@andudi
Copy link

andudi commented Apr 18, 2021

with this commit, binding of switch and sensors are working like a charm, thank you!

@dpozimski
Copy link

on my side it's working too

@@ -9413,6 +9414,7 @@ void DeRestPluginPrivate::updateSensorNode(const deCONZ::NodeEvent &event)
i->modelId().startsWith(QLatin1String("outlet")) || // Samsung SmartThings IM6001-OTP/IM6001-OTP01
i->modelId() == QLatin1String("3200-Sgb") || // Samsung/Centralite smart outlet
i->modelId() == QLatin1String("3200-de") || // Samsung/Centralite smart outlet
i->modelId().startsWith(QLatin1String("lumi.switch.n0agl1"))) // Xiaomi Aqara Single Switch Module T1 (With Neutral)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this line be:
i->modelId().startsWith(QLatin1String("lumi.switch.n0agl1")) ||

@manup manup merged commit 820c5db into dresden-elektronik:master Apr 22, 2021
@SwoopX SwoopX linked an issue Apr 23, 2021 that may be closed by this pull request
@SwoopX SwoopX deleted the aqarat1switch branch April 23, 2021 23:03
@cobch
Copy link
Contributor

cobch commented Dec 27, 2021

Does sensors appear in deconz? I only get switch entity but no luck with sensors such as power or energy. Please update whether it is working or not since I will return my aqara module otherwise )-';

@andudi
Copy link

andudi commented Dec 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aqara Single Switch Module T1 (With Neutral) Aqara Single Switch Module T1 (with Neutral)
5 participants