-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for ELKO Super TR thermostat #3329
Conversation
I use the Elko Super TR in regulator mode, i.e. I create my own thermostat by having a zigbee thermometer in the bathroom where the heating is applied. In this mode the local heatsetpoint attribute is the load in %, i.e. 500 is mapped to 5%. I noticed that the Rest API is not allowing me to set a lower set point than 5% and higher than 30%. I have tracked the problem to this PR: #3155. (thermostat.cpp) Should this sanity check be dependent on the device? I noticed that the attributes 0x0003 (abs min heat setpoint limit) and (0x0004 (max heat setpoint limit) change depending if I use regulator or thermostat mode, but I don't know if all manufacturers use these attributes. Should I make a new issue since this is not only related to Elko Super TR device support? |
What sanity check? The PR doesn't include anything you're referring to as far as I can tell. Each thermostat handles the min/max values differently and the attributes you mentioned are not responsible for setting the boundaries. So bottom line is: it's a zoo out there. |
I was referring to this line: |
This is irrelevant as it applies for on-device schedules only. |
Ok. Sorry, I did not trace to the correct section. I am guessing the sanity check of requests are within resource.cpp? |
Erm, that's gonna be funny. Setheatpoint is degrees, not percent. In that sense, you' try to set the thermostat to 50° 😂 Maybe I can discuss with the others |
The great work that you have done, have brought us all a long step further. Fantastic! |
Correct. But note that this is the deconz rest api plugin repo, so you need to raise it at the phoscon-beta repo. Technically, the device is ready for use. |
OK, so I have now files a new Device Request in the phoscon-beta repo here: |
Improve support for ELKO Super TR thermostat (#1291, #3123)
Enablement of sensor bindings is not included, but covered by a different PR (#3409).
state/floortemperature
,state/heating
andconfig/temperaturemeasurement
to REST APIstate/floortemperature
provides the floor temperature in addition, analog to the already given temperature (Int16)state/heating
indicates if heating is active/inactive (Bool)config/temperaturemeasurement
sets the mode of operation and allows to set the following string values: air sensor, floor sensor, floor protectionstate/on