Slp2 #3005
Merged
Slp2 #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwoopX
reviewed
Jul 1, 2020
bindings.cpp
Outdated
Comment on lines
1215
to
1221
| else if (sensor && (sensor->modelId() == QLatin1String("SLT2"))) | ||
| { | ||
| rq.attributeId = 0x0020; // battery voltage | ||
| rq.minInterval = 3600; | ||
| rq.maxInterval = 3600; | ||
| rq.reportableChange8bit = 0; | ||
| } |
There was a problem hiding this comment.
Just move the modelid like 20 lines up to prevent unnecessary code
SwoopX
reviewed
Jul 1, 2020
Comment on lines
+4314
to
+4329
| // Hive devices, don't show model id faster enought | ||
| if ((node->nodeDescriptor().manufacturerCode() == VENDOR_ALERTME) && (modelId.isEmpty())) | ||
| { | ||
| } | ||
| // Don't create entry for the plug | ||
| else if (modelId == QLatin1String("SLP2b")) | ||
| { | ||
| } | ||
| // Don't create entry for cluster 0x07 and 0x08 | ||
| else if ((modelId == QLatin1String("SLR2")) && (i->endpoint() > 0x06 )) | ||
| { | ||
| } | ||
| else | ||
| { | ||
| fpTemperatureSensor.inClusters.push_back(ci->id()); | ||
| } |
There was a problem hiding this comment.
Maybe better with || to safe some lines?
There was a problem hiding this comment.
IDK, It don't make a big difference on compiled file.
And I think like this it's easier to understand, It s not like your previous comment (the modelID enumeration)
The first test is to skip the test if there is no model ID, the second is a modelid check, the third is endpoint specific and can change later (there is some "black zone" on theses devices)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding devices from Hives
The PR is finished.
We still missing the second relay for SLR2, but need gateway sniffing, so will be done later.