Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device enhancements and additions #2959

Merged
merged 29 commits into from
Jul 10, 2020
Merged

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented Jun 16, 2020

@SwoopX SwoopX requested a review from ebaauw June 27, 2020 21:29
@SwoopX
Copy link
Collaborator Author

SwoopX commented Jun 27, 2020

@ebaauw Could you please double check the amendments for the groups?

Copy link
Collaborator

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both action and alert are write-only (i.e. they don't reflect the actual state of any light (in the group)), so hard-coding action.alert to return "none" seems fine for API v1.

Occasionally, nodes do only show a crippled set of clusters based on received reporting. This happens if the active endpoint request during pairing gets lost. The code now sends a 2nd one directly after receiving a node descriptor response to compensate that.
@manup manup merged commit 50c4754 into dresden-elektronik:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants