Skip to content

Commit

Permalink
Adjusted GitHub action to generate and upload release asset.
Browse files Browse the repository at this point in the history
  • Loading branch information
Ralph Gasser committed May 19, 2021
1 parent 156fa1c commit 1dfb7ff
Showing 1 changed file with 1 addition and 18 deletions.
19 changes: 1 addition & 18 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ on:
tags:
- 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10

env:
IMAGE_NAME: dres

jobs:
build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -49,18 +46,4 @@ jobs:
upload_url: ${{ steps.create_release.outputs.upload_url }} # This pulls from the CREATE RELEASE step above, referencing it's ID to get its outputs object, which include a `upload_url`. See this blog post for more info: https://jasonet.co/posts/new-features-of-github-actions/#passing-data-to-future-steps
asset_path: ./backend/build/distributions/dres-dist.tar
asset_name: dres-dist-${{ env.VERSION }}.tar
asset_content_type: application/tar
- name: Build Docker Image
run: docker build . --file Dockerfile --tag ${{ env.IMAGE_NAME }}
- name: Log into Docker Registry
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login docker.pkg.github.com -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
- name: Push Docker image
run: |
IMAGE_ID=docker.pkg.github.com/dres-dev/dres/${{ env.IMAGE_NAME }}
# Use Docker `latest` tag convention
[ "$VERSION" == "master" ] && VERSION=latest
echo IMAGE_ID=$IMAGE_ID
echo VERSION=$VERSION
docker tag $IMAGE_NAME $IMAGE_ID:$VERSION
docker push $IMAGE_ID:$VERSION
asset_content_type: application/tar

1 comment on commit 1dfb7ff

@lucaro
Copy link
Collaborator

@lucaro lucaro commented on 1dfb7ff May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, since we ship some platform specific components, this needs to be labelled with 'linux_x64'.

Please sign in to comment.