Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment scraping #693

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

HorstSoftware
Copy link

@HorstSoftware HorstSoftware commented Oct 21, 2021

This PR would solve issue #554

Basically, this code extends the getVideoMeta() function.
The comment scraping uses the corresponding API endpoint, which requires authentication.

  • Hence, this will only work if a user provides a valid session.
  • Also, downloading will only happen if the new parameter includeComments is set. This parameter is also available via CLI.
    So, this new feature will not change any of the current behavior of this program.

Would be awesome if this could be merged. :)

Let me hear, if you think that anything should be done differently.

@josx
Copy link

josx commented Oct 26, 2021

Hey great work.
I need this feature so i was testing it and it works ok.
Please merge this Feature soon.

Suggestions:
Comments can be very numerous and have a lot of fields, so maybe it is better to have this feature like video, hashtag on cli like tiktok-scraper comments [ID]

@HorstSoftware
Copy link
Author

Suggestions: Comments can be very numerous and have a lot of fields, so maybe it is better to have this feature like video, hashtag on cli like tiktok-scraper comments [ID]

Yeah, I thought about making it a separate option.

Currently, you would call it like this on the cli:
tiktok-scraper video --includeComments [ID]

So, without the option --includeComments, it still only downloads the video, which is important, because comments can indeed be very numerous.

In my opinion, comments are not so useful without the video they belong to, so I added it to the video download feature.
However, I'm open to make it a separate call, if the project maintainer wishes so.

@Romvnly-Gaming
Copy link

Any updates on this? This is a crucial feature! ❤️

@dongshou
Copy link

is there any new message about getting comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants