Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete task job and list tasks job in scheduler job implementation. #3401

Closed

Conversation

IRONICBo
Copy link
Contributor

Description

Add a delete task job and list tasks job implementation to the scheduler's async job to receive incoming jobs from the manager and call grpc's interface to complete tasks queries and deletions.

Related Issue

Motivation and Context

Introduced internaljob configuration parameters and job calls to asynchronously list or delete peers and task information for associated tasks in the scheduler.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@IRONICBo IRONICBo requested a review from a team as a code owner July 30, 2024 05:35
@IRONICBo IRONICBo changed the title feat: add delete task job and list tasks job in scheduler job implementation feat: add delete task job and list tasks job in scheduler job implementation. Jul 30, 2024
@IRONICBo IRONICBo marked this pull request as draft July 30, 2024 12:12
@IRONICBo IRONICBo force-pushed the feat/add-delete-task-scheduler-job branch from d6afb3e to 1d25119 Compare August 5, 2024 12:17
@IRONICBo IRONICBo marked this pull request as ready for review August 5, 2024 17:11
@IRONICBo IRONICBo force-pushed the feat/add-delete-task-scheduler-job branch from c4871c8 to 0526bf6 Compare August 5, 2024 17:12
@IRONICBo IRONICBo force-pushed the feat/add-delete-task-scheduler-job branch from 0526bf6 to 819583e Compare August 9, 2024 02:45
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.69%. Comparing base (83450d5) to head (819583e).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3401      +/-   ##
==========================================
- Coverage   52.76%   52.69%   -0.07%     
==========================================
  Files         193      193              
  Lines       20485    20493       +8     
==========================================
- Hits        10808    10799       -9     
- Misses       8873     8885      +12     
- Partials      804      809       +5     
Flag Coverage Δ
unittests 52.69% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@IRONICBo IRONICBo closed this Aug 9, 2024
@IRONICBo
Copy link
Contributor Author

IRONICBo commented Aug 9, 2024

Cherry-pick commits to #3378.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant