Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize tls cert expire check #3394

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jul 23, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner July 23, 2024 10:35
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (29ab308) to head (24bfcd7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3394      +/-   ##
==========================================
+ Coverage   52.61%   52.63%   +0.01%     
==========================================
  Files         192      192              
  Lines       20439    20439              
==========================================
+ Hits        10755    10758       +3     
+ Misses       8881     8880       -1     
+ Partials      803      801       -2     
Flag Coverage Δ
unittests 52.63% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
client/daemon/proxy/proxy.go 15.28% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xujihui1985 xujihui1985 merged commit 6d21c53 into main Jul 25, 2024
29 checks passed
@xujihui1985 xujihui1985 deleted the chore/optimize-tls-cert-expire-check branch July 25, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants