Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: peer automatically injects existing task metadata to scheduler upon restart #3385

Closed
wants to merge 1 commit into from

feat: peer injects existing task metadata to scheduler at startup

d353508
Select commit
Loading
Failed to load commit list.
Closed

feat: peer automatically injects existing task metadata to scheduler upon restart #3385

feat: peer injects existing task metadata to scheduler at startup
d353508
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 29, 2024 in 0s

52.07% (target 49.00%)

View this Pull Request on Codecov

52.07% (target 49.00%)

Details

Codecov Report

Attention: Patch coverage is 67.39130% with 30 lines in your changes missing coverage. Please review.

Project coverage is 52.07%. Comparing base (2c0ae78) to head (d353508).

Files with missing lines Patch % Lines
scheduler/service/service_v2.go 70.45% 25 Missing and 1 partial ⚠️
scheduler/rpcserver/scheduler_server_v2.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
- Coverage   52.09%   52.07%   -0.03%     
==========================================
  Files         188      188              
  Lines       20242    20332      +90     
==========================================
+ Hits        10546    10588      +42     
- Misses       8897     8940      +43     
- Partials      799      804       +5     
Files with missing lines Coverage Δ
scheduler/metrics/metrics.go 8.24% <ø> (ø)
scheduler/rpcserver/scheduler_server_v2.go 2.56% <0.00%> (-0.14%) ⬇️
scheduler/service/service_v2.go 81.40% <70.45%> (-1.00%) ⬇️

... and 6 files with indirect coverage changes