Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update api verison to v2.0.141 #3384

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

BruceAko
Copy link
Contributor

@BruceAko BruceAko commented Jul 18, 2024

Description

  1. Update api version.
  2. Add methods for scheduler rpcserver.

Commands:

go get -u d7y.io/api/v2
go mod tidy

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@BruceAko BruceAko requested a review from a team as a code owner July 18, 2024 08:08
@BruceAko BruceAko changed the title chore: update api verison to v2.0.141 [WIP]chore: update api verison to v2.0.141 Jul 18, 2024
@BruceAko BruceAko changed the title [WIP]chore: update api verison to v2.0.141 chore: update api verison to v2.0.141 Jul 18, 2024
@BruceAko
Copy link
Contributor Author

@gaius-qi PTAL

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (3b740db) to head (92598be).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3384      +/-   ##
==========================================
+ Coverage   52.68%   52.73%   +0.04%     
==========================================
  Files         192      192              
  Lines       20433    20439       +6     
==========================================
+ Hits        10765    10778      +13     
+ Misses       8869     8863       -6     
+ Partials      799      798       -1     
Flag Coverage Δ
unittests 52.73% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/rpcserver/scheduler_server_v2.go 2.70% <0.00%> (-0.24%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit ac52afc into dragonflyoss:main Jul 19, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants