Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update api protoc version to v2.0.118 #3326

Merged
merged 1 commit into from
Jun 17, 2024
Merged

feat: update api protoc version to v2.0.118 #3326

merged 1 commit into from
Jun 17, 2024

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Jun 17, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Jun 17, 2024
@gaius-qi gaius-qi self-assigned this Jun 17, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner June 17, 2024 07:57
@gaius-qi gaius-qi force-pushed the feature/protoc branch 2 times, most recently from bd6c9e4 to baecacc Compare June 17, 2024 08:31
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 13.20755% with 46 lines in your changes missing coverage. Please review.

Project coverage is 52.58%. Comparing base (1c9484a) to head (40528ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   52.70%   52.58%   -0.13%     
==========================================
  Files         192      192              
  Lines       20427    20456      +29     
==========================================
- Hits        10766    10756      -10     
- Misses       8857     8893      +36     
- Partials      804      807       +3     
Flag Coverage Δ
unittests 52.58% <13.20%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/scheduling/scheduling.go 84.05% <100.00%> (ø)
scheduler/service/service_v2.go 82.16% <75.00%> (-0.16%) ⬇️
scheduler/rpcserver/scheduler_server_v2.go 3.57% <0.00%> (+0.39%) ⬆️
scheduler/resource/seed_peer_client_mock.go 19.44% <0.00%> (-6.98%) ⬇️

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit a370304 into main Jun 17, 2024
28 checks passed
@gaius-qi gaius-qi deleted the feature/protoc branch June 17, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant