chore: Add FakeRedis capture/compare to more cluster tests and seed during migration #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we can't add such a test to `test_cluster_native_client` because we don't do a migration there, just re-assign slots, meaning that data is lost (by desgin?) Fixes #4429
kostasrim
reviewed
Feb 3, 2025
This is just a "free" step, which we compare ourselves to FakeRedis. Sort of sanity check to see that we behave like Redis does. We're supposed to take this further and seed during migration, then compare to FakeRedis. So far we didn't do it because we didn't have anything to compare against, as traffic sent during migration was only available to the target node once the migration finished. |
kostasrim
previously approved these changes
Feb 3, 2025
chakaz
changed the title
|
@kostasrim I now added the remainder of the tests (originally I thought about doing so in a separate PR, but I gave up on that due to time considerations). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we can't add such a test to
test_cluster_native_clientbecause we don't do a migration there, just re-assign slots, meaning that data is lost (by desgin?)Fixes #4429