Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not omit dracut modules for initramfs.testing #2258

Closed
wants to merge 1 commit into from

Conversation

LaszloGombos
Copy link
Collaborator

@LaszloGombos LaszloGombos commented Mar 3, 2023

We want to know if including dracut modules makes the test fail instead of masking issues by omitting dracut modules.

This PR increase test coverage and makes the tests simpler to maintain.

This PR exposed an issue with multipath dracut module for full systemd test (test 04). For now limit this PR just for changing tests, so disable multipath from kernel command line to keep the test passing.

The exposed new issue confirms the reasoning behind why this PR increases test coverage.

@LaszloGombos
Copy link
Collaborator Author

LaszloGombos commented Mar 4, 2023

Feel free to start the review, but please do not land. I hope to land #2260 first and rebase this PR on top of #2260 .

This PR exposed an issue with multipath dracut module for full systemd test (test 04).

I think issue #2175 might be related.

@LaszloGombos LaszloGombos changed the title tests: do not omit dracut modules for initramfs.testing test: do not omit dracut modules for initramfs.testing Mar 5, 2023
@stale
Copy link

stale bot commented Apr 5, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Apr 5, 2023
@stale stale bot closed this Apr 26, 2023
@LaszloGombos LaszloGombos removed the stale communication is stuck label May 8, 2023
@LaszloGombos LaszloGombos removed the request for review from danimo May 8, 2023 18:25
@LaszloGombos LaszloGombos added this to the dracut-060 milestone May 8, 2023
@LaszloGombos LaszloGombos reopened this May 8, 2023
@LaszloGombos LaszloGombos removed this from the dracut-060 milestone May 8, 2023
@LaszloGombos LaszloGombos force-pushed the omitt branch 3 times, most recently from 4b9cba2 to 58e51dd Compare May 8, 2023 19:30
We want to know if including dracut modules makes the test fail
instead of masking issues by omitting dracut modules.

Disable multipath for full systemd test until it is fixed. This
is an existing bug that is now more exposed with this change.
@stale
Copy link

stale bot commented Jul 14, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Jul 14, 2023
@stale stale bot closed this Aug 9, 2023
@LaszloGombos LaszloGombos reopened this Jan 29, 2024
@stale stale bot removed the stale communication is stuck label Jan 29, 2024
Copy link

stale bot commented Mar 13, 2024

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale communication is stuck test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant