Fixes for the dune-fem linear solver backend #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMGXSolverBackend and various smaller fixes to accommodate this.
most importantly, the base discretization does not need any modification anymore and the FEM backend is used for a test if a suitable version of dune-fem is available.
… adapter so far, this property was specified by the level of the base discretization. because explicitly set properties overwrite the stuff inherited from splices, so far it was not possible to use a linear solver backends which requires a custom sparse matrix adapter unless the sparse matrix adapter adapter class was explicitly set again at the problem level -- thus making the splice much less generic than it ought to be. (also, the whole point of the sparse matrix adapter abstraction is that the discretization does not need to know what it does internally.)
dr-robertk
pushed a commit
that referenced
this pull request
Jun 20, 2022
guard against missing opm-grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the abstractions of the backends introduced by OPM#511. note that I only tested the
FemSolverBackend, so your milage with theAmgXSolverBackendandPetscSolverBackendclasses will vary. (the adaptations required for them should be small, though.)Also, I noticed that using the
FemSolverBackendfor thelens_immiscible_ecfv_adtest regresses linear solver performance by more than factor 2 on my machine (0.425 seconds for the linear solver withFemSolverBackendversus 0.196 seconds with the default)