-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Melanie #541
base: main
Are you sure you want to change the base?
Melanie #541
Conversation
… checked the limit as r goes to zero with LHopital's rule, then rewrote the code
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments (see below) about typesetting in the report changes you made. If this is what you really want, let me know and I will merge into the main branch.
"\\begin{align*}\n", | ||
" -\\frac{1}{r^2}\\bigl(-D_1\\, r^2 u_1'\\bigr)'(r) - \\Sigma_{a,1}\\,u_1(r) + s_{0,1} &= 0 \\quad\\quad \\forall \\quad\\quad r\\in\\ ]0,R[, \\\\\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminating the small space makes the equation look odd since the diffusion coefficient shows up too close to the unknown variable. Proper typesetting calls for a small space to make the distinction. Note the difference
@@ -179,13 +180,13 @@ | |||
"\n", | |||
"\\begin{align*}\n", | |||
"y = c_1 e^{m_1x} + c_2 e^{m_2 x} \n", | |||
" + \\frac{e^{m_1x}}{m_1-m_2} \\int R\\left(x\\right) e^{-m_1x} \\, dx\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integrand and the differential should be separated by a space:
"\\end{align*}\n", | ||
"\n", | ||
"where $a$ and $b$ are constants, and $m_1$ and $m_2$ are the real and distinct roots of $m^2+am+b=0$.\n", | ||
"\n", | ||
"Thus, for $w_i=r\\,u_i$, $a=0$, $b=-\\frac{\\Sigma_{a,i}}{D_i}$, $R=- r\\frac{s_{0,i}}{D_i}$, and the roots are\n", | ||
"Thus, for $w_i=r u_i$, $a=0$, $b=-\\frac{\\Sigma_{a,i}}{D_i}$, $R=- r\\frac{s_{0,i}}{D_i}$, and the roots are\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you proposing:
No description provided.