Fixed query_images() for compatibility with Plugin "WP-Offload-S3" #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin "WP-Offload-S3" is installed, the attachments are stored at AWS S3 and are available either per S3 or via AWS Cloudfront and not necessarily hosted on the server being available at ABSPATH.
In this case, file_exists() will check the wrong filepath here.
In my PR i'm checking the hostname of the image URLs again the hostname of the wordpress installation and, if they are different, i just pass the information from wp_get_attachment_image_src(), which contains the full path to S3/Cloudfront, and renounce calls to file_exists() and getimagesize().
I reverted the first commit because i forgot to create a branch first.