Replace Hydrate #244
Closed
Replace Hydrate #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently having question marks on what to do with PropertyOf and ChildOf. PropertyOf currently returns a Computed wrapping a value to create a read-only state, but the current issue is that we create a connection that updates the value (and thus the computed) whenever the property is changed. How will we ensure this connection is cleaned up with the Computed when it is no longer used? ChildOf also is a weird one. Do we have to support states here? Should it return a state? Currently it's just a fancy wrapper for |
|
There hasn't been a lot of motion on this issue, and Fusion's seen fundamental changes in the intervening time, so I'm closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature requests from #124? and #206
Currently still a draft as there are still a lot of question marks and #124 still needs design.