Adding the changes for segregation of PHP & html code from controller to template #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Team @dpdplugin ,
We have done the changes for segregating the PHP and HTML code from the Controller file Index.php to the two template files. We have divided the HTML code in two separate phtml files (parcelshop-marker.phtml & parcelshop-opening-hours.phtml). We have taken the reference of Single-responsibility Principle from SOLID principles. By using this way, controller will be responsible only for routing, some part of calculation and not for rendering the HTML code. Please let us know your suggestions on this and also let us know if anything is required from our end.
Thanks,
Parth