-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use macOS vz
VM type and virtiofs
mounts
#42
Conversation
41125d3
to
f8107c0
Compare
Preliminary tests on a production CI pipeline show a speedup of almost |
vz
VM type and virtiofs
mounts
Now that the action dropped support for macOS < 13, it makes sense to rely on macOS native virtualization, hoping to boost performance during tests. This update also gets rid of the QEMU requirement, which has been historically difficult to be maintained properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GlassOfWhiskey this looks super promising, thanks! Can you add a changelog entry, please? The changelog file contains a few examples already.
I just did it. As you can see, I fully removed QEMU. If you prefer, I can leave it as a backup option. However, this will mean that two different virtualization technologies should be maintained. |
@GlassOfWhiskey I think we are fine completely getting rid of QEMU. We can merge this now and let it cook for a while -- you can use the action directly from the |
@douglascamata I agree. I also have another PR regarding volume mounts to submit, so if this is merged I can easily start working on the other one. With a bit of luck, they could be released together with a single release process :) |
Now that the action dropped support for macOS < 13, it makes sense to rely on macOS native virtualization, hoping to boost performance during tests.