Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macOS vz VM type and virtiofs mounts #42

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

GlassOfWhiskey
Copy link
Contributor

Now that the action dropped support for macOS < 13, it makes sense to rely on macOS native virtualization, hoping to boost performance during tests.

@GlassOfWhiskey GlassOfWhiskey force-pushed the main branch 4 times, most recently from 41125d3 to f8107c0 Compare November 24, 2024 20:34
@GlassOfWhiskey
Copy link
Contributor Author

GlassOfWhiskey commented Nov 24, 2024

Preliminary tests on a production CI pipeline show a speedup of almost 1.4x and a much better stability: the pipeline never broke during colima startup.

@GlassOfWhiskey GlassOfWhiskey changed the title Use macOS vz VM type and virtiofs mounts Use macOS vz VM type and virtiofs mounts Nov 24, 2024
Now that the action dropped support for macOS < 13, it makes sense to
rely on macOS native virtualization, hoping to boost performance during
tests. This update also gets rid of the QEMU requirement, which has been
historically difficult to be maintained properly.
Copy link
Owner

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GlassOfWhiskey this looks super promising, thanks! Can you add a changelog entry, please? The changelog file contains a few examples already.

@GlassOfWhiskey
Copy link
Contributor Author

@GlassOfWhiskey this looks super promising, thanks! Can you add a changelog entry, please? The changelog file contains a few examples already.

I just did it. As you can see, I fully removed QEMU. If you prefer, I can leave it as a backup option. However, this will mean that two different virtualization technologies should be maintained.

@douglascamata
Copy link
Owner

douglascamata commented Nov 24, 2024

@GlassOfWhiskey I think we are fine completely getting rid of QEMU. We can merge this now and let it cook for a while -- you can use the action directly from the main branch. If there are no further issues with the new virtualization tech, I'll cut a release on Friday or Saturday. What do you think?

@GlassOfWhiskey
Copy link
Contributor Author

@douglascamata I agree. I also have another PR regarding volume mounts to submit, so if this is merged I can easily start working on the other one. With a bit of luck, they could be released together with a single release process :)

@douglascamata douglascamata merged commit f533885 into douglascamata:main Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants