Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/static linking #554

Closed

Conversation

landerverhacklansweeper
Copy link
Contributor

No description provided.

KoenPlasmansLS and others added 30 commits May 7, 2022 09:19
feat: extract and expand interface + fix test
feat: extracted interface and changed version
@kayoub5
Copy link
Collaborator

kayoub5 commented Jan 15, 2025

@landerverhacklansweeper @KoenPlasmansLS @Lansweeper

Why not contribute those changes to the official repo, instead of rolling your own fork?

@landerverhacklansweeper
Copy link
Contributor Author

Hey, @kayoub5. I created this PR by accident.

I don't think any of these changes are beneficial to this repository. E.g., we removed support for .netstandard2.0 in our fork to simply certain things. But this repo should keep that support in my opinion. The only things that might be useful are the following commits

  • 6c8f6b9
    Small improvement avoiding typeof() --> replace with generics (recommended for AoT)

  • 6b769dc
    using pcap_open_live instead of pcap_open, because pcap_open doesn't work when using libpcap.a (static linking). This works great for our case. But I'm not entirely sure this is what everybody wants.

I'm really happy to see you are so on top of this project. If you like, I'll gladly create a PR for those two commits.
I might also look into adding nullable checks in the repo. And maybe replace [DllImport] with [LibraryImport]. This is something that could be a nice contribution in the future.

@kayoub5
Copy link
Collaborator

kayoub5 commented Jan 16, 2025

all topics look welcome as PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants