Fix ToolStrip's ToolTip issues #12832
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStrip.cs:3289
- Ensure that there are tests covering the behavior of tooltips being removed when the control loses focus.
ToolTip.RemoveAll();
Epica3055
force-pushed
the
Fix_issues_12819
branch
from
f15cc3e to
f8aefcb
Compare
…layed after expanded and collapsed the toolStripDropDownbutton in toolStrip1, then tab to toolStrip2's item fix dotnet#12819 : Keyboard tooltip of toolStripDropDownbutton in toolStrip1 is displayed after expanded and collapsed the toolStripDropDownbutton in toolStrip2
Epica3055
force-pushed
the
Fix_issues_12819
branch
from
f8aefcb to
810320c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12832 +/- ##
===================================================
- Coverage 76.17317% 76.13736% -0.03581%
===================================================
Files 3240 3240
Lines 642343 642343
Branches 47270 47270
===================================================
- Hits 489293 489063 -230
- Misses 149509 149738 +229
- Partials 3541 3542 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
reviewed
Jan 24, 2025
| @@ -3286,7 +3286,7 @@ protected override void OnLostFocus(EventArgs e) | |||
| { | |||
| base.OnLostFocus(e); | |||
| ClearAllSelections(); | |||
| ToolTip.Hide(this); | |||
| ToolTip.RemoveAll(); | |||
There was a problem hiding this comment.
Call ToolTip.RemoveAll(), all associated tooltips should be deleted. Please confirm whether the Tooltip will be displayed again when the control gets focus again
Please send it to the test team for further verification
Tanya-Solyanik
added
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12818,#12819
Proposed changes
ToolStriploses focus, remove all tooltips.Regression?
Risk
Screenshots
Before
Issue1.mp4
Issue2.mp4
After
PR_12832.mp4
Test methodology
Test environment(s)
.Net 10.0.0-alpha.1.25072.13