Add convenience / perf methods to ListViewItem/ControlCollection #10944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
....Windows.Forms/src/System/Windows/Forms/Controls/ListView/ListView.ListViewItemCollection.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/10.0 #10944 +/- ##
======================================================
+ Coverage 74.22517% 75.09169% +0.86651%
======================================================
Files 3020 3119 +99
Lines 626328 656865 +30537
Branches 46693 51738 +5045
======================================================
+ Hits 464893 493251 +28358
- Misses 158039 160207 +2168
- Partials 3396 3407 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
…numerable<ListViewItem>`, which necessitates unnecessary array allocations when adding from a collection. It also doesn't implement a generic `IList<T>` which makes typed usage and LINQ usage difficult. This adds that. Also add `IEnumerable<Control>` to `ControlCollection` to address the LINQ scenario. Control has `IList`, but indexed setting throws. I don't want to add `IList<Control>` until we've had time to evaluate the implications of implicitly doing the public steps with the collection that replicate what those setters should be doing. Also tweak `ArrangedElementCollection` so the static empty collection can't be written to. This doesn't fix the ambiguity of `AddRange([..])` with `ListViewItemCollection`, but it does avoid the need for it in some cases.
JeremyKuhne
force-pushed
the
listviewitemcollection
branch
from
a3ca32b to
2bad759
Compare
lonitra
previously approved these changes
May 3, 2024
|
@JeremyKuhne was there anything blocking merging this? |
Ran out of bandwidth to figure out the best way to implement improvements here that are consistent across our internal collections. I hope to come up with a proposal that API review will be happy with... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListViewItemCollectiondoesn't have anAddRangethat takes anIEnumerable<ListViewItem>, which necessitates unnecessary array allocations when adding from a collection.It also doesn't implement a generic
IList<T>which makes typed usage and LINQ usage difficult. This adds that.Also add
IEnumerable<Control>toControlCollectionto address the LINQ scenario. Control hasIList, but indexed setting throws. I don't want to addIList<Control>until we've had time to evaluate the implications of implicitly doing the public steps with the collection that replicate what those setters should be doing.Also tweak
ArrangedElementCollectionso the static empty collection can't be written to.This doesn't fix the ambiguity of
AddRange([..])withListViewItemCollection, but it does avoid the need for it in some cases.Microsoft Reviewers: Open in CodeFlow