-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "PDB distributions" section of README #1271
base: main
Are you sure you want to change the base?
Conversation
I originally wrote this change as part of #1270, but separated it into its own PR since this one is a bit more nuanced and contains some opinions instead of just facts. More specifically, the only downside I see for advocating for embedded pdbs over separate files included in the main package is it's easier to strip separate files for people that really care about size. I'm not convinced that requiring every consumer to opt-in via |
@tmat, would you mind taking a look at this when you have a second? If you have any questions or concerns, please let me know. Thanks! |
|
||
Alternatively, you can include PDB files in the main NuGet package by setting the following property in your project: | ||
|
||
```xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest including portable PDBs in the nupkg first and embedding PDBs into the assembly as an alternative. The latter increases size of the assembly, which may potentially be an issue in some cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand on what the issues are? I can imagine that it slows down assembly loading. Anything else? I'll add it into the document as a caveat. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did an update assuming the assembly load costs are the main issue. As part of this update, I also added a small pros / cons table to make it easier to understand the main tradeoffs, then gave each alternative its own section.
Refactor the "PDB distributions" section of the README so that:
CopyDebugSymbolFilesFromPackages
Fixes #255