-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the trim requirements on MetadataUpdateHandlerAttribute #84369
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsFixes #66069
|
@vitek-karas I tried updating MetadataUpdateHandlerAttribute but got compatibility errors with .net7.0. |
This is hitting the same problem as #84326 - just different attribute. Do we have a way to baseline just one specific attribute difference - as intentional? |
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsFixes #66069
|
In 7.0 we had that allowed us to baseline specific known API compat issues. But I'm not seeing this in main. @ericstj, @ViktorHofer ? |
It's the new format in Main: https://github.com/dotnet/runtime/blob/main/src/libraries/apicompat/ApiCompatBaseline.NetCoreAppLatestStable.xml You could modify it directly, or try generating it. To generate it you could do:
|
@pedrobsaila thanks for this contribution. |
Fixes #66069