Extend preinitialization interpreter to support calling string::Length
#78680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support `callvirt` to a non-virtual method * Support accessing string's fields
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
A bit of progress towards #78093 (comment). Cc @dotnet/ilc-contrib
|
| @@ -598,6 +607,11 @@ private Status TryScanMethod(MethodIL methodIL, Value[] parameters, Stack<Method | |||
| return Status.Fail(methodIL.OwningMethod, opcode, "Reference field"); | |||
| } | |||
|
|
|||
| if (field.FieldType.IsByRef) | |||
| { | |||
| return Status.Fail(methodIL.OwningMethod, opcode, "Byref field"); | |||
There was a problem hiding this comment.
This is not strictly necessary because we would throw/catch exception later, but ideally we should only do throw/catch on invalid programs.
jkotas
reviewed
Nov 23, 2022
| Debug.Assert(firstCharField.FieldType.IsWellKnownType(WellKnownType.Char) | ||
| && firstCharField.Offset.AsInt == pointerSize + sizeof(int) /* length */); | ||
|
|
||
| value.CopyTo(MemoryMarshal.Cast<byte, char>(((Span<byte>)bytes).Slice(firstCharField.Offset.AsInt))); |
There was a problem hiding this comment.
This would not work for little-endian/big-endian cross-compilation, but it is not the first problem of this kind in the aot interpreter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callvirtto a non-virtual methodA bit of progress towards #78093 (comment).
Cc @dotnet/ilc-contrib