Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable System.Runtime.Serialization.Xml.Tests #68921

Merged
merged 4 commits into from
May 10, 2022
Merged

Reenable System.Runtime.Serialization.Xml.Tests #68921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51acc0d
Reenable `System.Runtime.Serialization.Xml.Tests`
radical May 5, 2022
612b996
Disable the test with `SkipOnPlatform` instead, for wasm, as it is
radical May 5, 2022
28b0c80
Merge remote-tracking branch 'origin/main' into enable-xml-ser-tests
radical May 6, 2022
2177db6
Merge branch 'dotnet:main' into enable-xml-ser-tests
radical May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4256,6 +4256,7 @@ public static void DCS_TypeWithPrimitiveKnownTypes()
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/1417", TestPlatforms.OSX)]
[SkipOnPlatform(TestPlatforms.Browser, "Causes a stack overflow")]
[Fact]
public static void DCS_DeeplyLinkedData()
{
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,6 @@

<!-- Aggressive Trimming related failures -->
<ItemGroup Condition="('$(TargetOS)' != 'Browser' and '$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true') or ('$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true')">
<!-- Issue: https://github.com/dotnet/runtime/issues/59926 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Serialization.Xml\tests\System.Runtime.Serialization.Xml.Tests.csproj" />
</ItemGroup>

<ItemGroup Condition="('$(TargetOS)' != 'Browser' and '$(RunAOTCompilation)' == 'true' and '$(MonoForceInterpreter)' != 'true') or ('$(TargetOS)' == 'Browser' and '$(BuildAOTTestsOnHelix)' == 'true' and '$(RunDisabledWasmTests)' != 'true') or ('$(TargetOS)' == 'iOS' and '$(BuildTestsOnHelix)' == 'true')">
Expand Down